Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to release checklist. #2772

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Updates to release checklist. #2772

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27e8125
Updates to release checklist.
markmandel Oct 20, 2022
269afe1
Review updates, and some other small tweaks.
markmandel Oct 21, 2022
72c1369
Merge branch 'main' into updates/release-checklist
roberthbailey Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions docs/governance/templates/release_issue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@ and copy it into a release issue. Fill in relevant values, found inside {}
- [ ] Have at least `Editor` level access to `agones-images` project.
- [ ] Have permission to publish new versions of the App Engine application.
- [ ] Have write access to Agones github repository.
- [ ] Have a `gcloud config configurations` configuration called `agones-images` that points to the same project.
- [ ] Run `git remote -v` and see"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing "

- [ ] An `origin` remote that points to a personal fork of Agones, such as `git@github.com:yourname/agones.git`.
- [ ] An `upstream` remote that points to `git@github.com:googleforgames/agones.git`.
- [ ] Have a [Github Personal Access Token](https://github.com/settings/tokens) with repo permissions.
- [ ] Have a `gcloud config configurations` configuration called `agones-images` that points to the same project.
- [ ] Edit access to the [Agones Release Calendar](https://calendar.google.com/calendar/u/0?cid=Z29vZ2xlLmNvbV84MjhuOGYxOGhmYnRyczR2dTRoMXNrczIxOEBncm91cC5jYWxlbmRhci5nb29nbGUuY29t)

## Steps
Expand Down Expand Up @@ -57,7 +60,6 @@ and copy it into a release issue. Fill in relevant values, found inside {}
- [ ] If full release, copy `dev_minikube_minor_supported_k8s` to `minikube_minor_supported_k8s`.
- [ ] If full release, update documentation with updated example images tags.
- [ ] Create PR with these changes, and merge them with an approval.
- [ ] Confirm local git remote `upstream` points at `git@github.com:googleforgames/agones.git`
- [ ] Run `git remote update && git checkout main && git reset --hard upstream/main` to ensure your code is in line
with upstream (unless this is a hotfix, then do the same, but for the release branch)
- [ ] Publish SDK packages
Expand All @@ -73,6 +75,7 @@ and copy it into a release issue. Fill in relevant values, found inside {}
(`helm install --namespace=agones-system agones agones/agones --version={version}-rc` if release candidate) and a smoke test to confirm everything is working.
- [ ] Attach all assets found in the `release` folder to the draft Github Release.
- [ ] If release candidate check the pre-release box on the draft Github Release
- [ ] Copy any review changes to the release blog post are copied into the draft Github release.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Ensure that any review changes ..." or "Copy any review changes into the draft ..."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ermagerd that sentence makes no sense. Thanks.

- [ ] Publish the draft Github Release.
- [ ] Send an email to the [mailing list][list] with the release details (copy-paste the release blog post)
- [ ] Paste the announcement blog post to the #users Slack group.
Expand Down