SDKWatchSendOnExecute to Stable #2353

SaitejaTamma · 2021-10-30T15:07:27Z

SDKWatchSendOnExecute to Stable

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

SDKWatchSendOnExecute to Stable

google-oss-robot · 2021-10-30T15:07:30Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SaitejaTamma
To complete the pull request process, please assign ericfortin after the PR has been reviewed.
You can assign the PR to them by writing /assign @ericfortin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2021-10-30T15:21:32Z

Build Failed 😱

Build Id: 81b1b75c-45e2-46d5-9a9c-2adb0d3900b1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

site/content/en/docs/Guides/feature-stages.md

pkg/sdkserver/sdkserver.go

review comment fixes

agones-bot · 2021-11-01T14:48:25Z

Build Failed 😱

Build Id: bcd315a5-e600-4bed-bfd6-7a5c6d5fd853

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

pkg/sdkserver/sdkserver_test.go

roberthbailey · 2021-11-03T15:55:49Z

A quick search also revealed that the feature is referenced in https://agones.dev/site/docs/guides/client-sdks/#watchgameserverfunctiongameserver, so you'll need to update https://github.com/googleforgames/agones/blob/main/site/content/en/docs/Guides/Client%20SDKs/_index.md as well (using the feature codes just like in https://github.com/googleforgames/agones/blob/main/site/content/en/docs/Guides/feature-stages.md).

agones-bot · 2021-11-04T06:50:46Z

Build Failed 😱

Build Id: dd230798-b97f-46a3-b81f-9af0a72473a3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

SDKWatchSendOnExecute to Stable

agones-bot · 2021-11-05T16:45:58Z

Build Failed 😱

Build Id: 0e3f8e3e-82fd-4dc7-b846-0c3266a0c8a9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-11-05T16:53:01Z

Build Failed 😱

Build Id: ba05d41d-58c6-4b9d-b1af-4c943e822d53

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

pkg/sdkserver/sdkserver_test.go

updated _index.md file

agones-bot · 2021-11-08T05:47:14Z

Build Failed 😱

Build Id: ba352a53-6468-446e-a05b-1675b4e0f473

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

updated feature-gates in feature-stages.md file

agones-bot · 2021-11-08T06:24:13Z

Build Failed 😱

Build Id: 36e96326-d3b8-49ce-bc6c-bfb1fbece973

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

site/content/en/docs/Guides/Client SDKs/_index.md

pkg/sdkserver/sdkserver_test.go

Updated The files index.md and sdkserver_test.go as required

agones-bot · 2021-11-09T13:58:39Z

Build Failed 😱

Build Id: e7f83ace-1882-44bd-8e72-5cb0a3e35668

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

site/content/en/docs/Guides/Client SDKs/_index.md

updated files sdkserver_test.go and _index.md

agones-bot · 2021-11-11T05:29:46Z

Build Failed 😱

Build Id: 474fb3c0-db9d-4597-b21d-c5ed5ea906dd

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

pkg/sdkserver/sdkserver_test.go

Updated the file

agones-bot · 2021-11-12T03:42:36Z

Build Failed 😱

Build Id: 251230f0-76b5-464d-8e7b-4fad9651e6d0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Updated file

agones-bot · 2021-11-12T04:43:07Z

Build Failed 😱

Build Id: 36b4c42a-0a50-4396-83d2-5044463cfab3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-11-12T07:08:27Z

e2e-stable failure:

--- FAIL: TestGameServerReserve (54.69s)
    gameserver_test.go:624: 
        	Error Trace:	gameserver_test.go:624
        	Error:      	Could not message GameServer
        	Test:       	TestGameServerReserve
        	Messages:   	read udp 192.168.10.4:51623->35.247.116.52:7540: i/o timeout

pkg/sdkserver/sdkserver_test.go

agones-bot · 2021-11-12T07:38:59Z

Build Failed 😱

Build Id: 4b1d9a3b-a6e3-439b-a078-8846cc3a166f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

updated the change

…a/agones into stable/SDKWatchSendOnExecute

agones-bot · 2021-11-12T13:01:11Z

Build Failed 😱

Build Id: 4a5a8136-9acc-457c-838b-52b1472be3d0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2021-11-12T18:51:30Z

Looks like TestAutoscalerBasicFunctions is being quite flaky these days.

markmandel

LGTM. Nice work 👍🏻

google-oss-prow · 2021-11-12T18:52:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, SaitejaTamma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2021-11-12T19:24:38Z

Build Failed 😱

Build Id: 0d98b431-0aa7-433b-b4f5-58d4a92baef3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2021-11-12T19:27:34Z

Flake: TestFleetAutoScalerRollingUpdate

agones-bot · 2021-11-12T19:58:10Z

Build Succeeded 👏

Build Id: 6d3a8c22-6d8b-4219-880e-f17659ce7d92

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.19.0-ad67560
image: gcr.io/agones-images/agones-ping:1.19.0-ad67560
Linux C++ SDK (build): agonessdk-1.19.0-ad67560-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.19.0-ad67560.zip

A preview of the website (the last 30 builds are retained):

https://ad67560-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2353/head:pr_2353 && git checkout pr_2353
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.19.0-ad67560

SDKWatchSendOnExecute to Stable

d62ed87

SDKWatchSendOnExecute to Stable

google-oss-robot requested a review from EricFortin October 30, 2021 15:07

google-oss-robot requested a review from markmandel October 30, 2021 15:07

google-cla bot added the cla: yes label Oct 30, 2021

google-oss-robot added the size/M label Oct 30, 2021

roberthbailey reviewed Oct 30, 2021

View reviewed changes

site/content/en/docs/Guides/feature-stages.md Outdated Show resolved Hide resolved

pkg/sdkserver/sdkserver.go Outdated Show resolved Hide resolved

review comment fixes

aab1090

review comment fixes

roberthbailey reviewed Nov 3, 2021

View reviewed changes

pkg/sdkserver/sdkserver_test.go Show resolved Hide resolved

roberthbailey reviewed Nov 3, 2021

View reviewed changes

SDKWatchSendOnExecute to Stable

c91f324

SDKWatchSendOnExecute to Stable

roberthbailey reviewed Nov 6, 2021

View reviewed changes

pkg/sdkserver/sdkserver_test.go Show resolved Hide resolved

pkg/sdkserver/sdkserver_test.go Show resolved Hide resolved

updated _index.md file

8238c85

updated _index.md file

updated feature-gates in feature-stages.md file

dc0f567

updated feature-gates in feature-stages.md file

roberthbailey reviewed Nov 8, 2021

View reviewed changes

site/content/en/docs/Guides/Client SDKs/_index.md Outdated Show resolved Hide resolved

site/content/en/docs/Guides/Client SDKs/_index.md Outdated Show resolved Hide resolved

pkg/sdkserver/sdkserver_test.go Show resolved Hide resolved

Updated The files as required

ce894e6

Updated The files index.md and sdkserver_test.go as required

roberthbailey reviewed Nov 10, 2021

View reviewed changes

site/content/en/docs/Guides/Client SDKs/_index.md Outdated Show resolved Hide resolved

updated files sdkserver_test.go and _index.md

9832ef3

updated files sdkserver_test.go and _index.md

google-oss-prow bot added size/L and removed size/M labels Nov 11, 2021

roberthbailey reviewed Nov 11, 2021

View reviewed changes

pkg/sdkserver/sdkserver_test.go Outdated Show resolved Hide resolved

SaitejaTamma mentioned this pull request Nov 11, 2021

Request Releaser role for Agones Repository #2368

Closed

5 tasks

Updated the file

857042a

Updated the file

updated file

2fd9f70

Updated file

Merge branch 'main' into stable/SDKWatchSendOnExecute

bd91623

roberthbailey reviewed Nov 12, 2021

View reviewed changes

pkg/sdkserver/sdkserver_test.go Outdated Show resolved Hide resolved

SaitejaTamma added 2 commits November 12, 2021 07:23

updated the change

5397d7e

updated the change

Merge branch 'stable/SDKWatchSendOnExecute' of github.com:SaitejaTamm…

ad67560

…a/agones into stable/SDKWatchSendOnExecute

markmandel approved these changes Nov 12, 2021

View reviewed changes

google-oss-prow bot assigned markmandel Nov 12, 2021

google-oss-prow bot added the lgtm label Nov 12, 2021

google-oss-prow bot added the approved label Nov 12, 2021

markmandel merged commit 849ed6f into googleforgames:main Nov 12, 2021

markmandel linked an issue Nov 12, 2021 that may be closed by this pull request

Move SDKWatchSendOnExecute to Stable #2238

Closed

markmandel mentioned this pull request Nov 12, 2021

Move SDKWatchSendOnExecute to Stable #2238

Closed

roberthbailey mentioned this pull request Nov 13, 2021

Remove mention of the SDKWatchSendOnExecute feature gate in a comment in sdkserver_test.go #2373

Merged

SaitejaTamma added this to the 1.19.0 milestone Nov 16, 2021

SaitejaTamma added the kind/feature New features for Agones label Nov 16, 2021

scrayos mentioned this pull request Jan 19, 2022

Initial GameServer state is not sent on watch with local SDK server #2437

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDKWatchSendOnExecute to Stable #2353

SDKWatchSendOnExecute to Stable #2353

SaitejaTamma commented Oct 30, 2021

google-oss-robot commented Oct 30, 2021

agones-bot commented Oct 30, 2021

agones-bot commented Nov 1, 2021

roberthbailey commented Nov 3, 2021

agones-bot commented Nov 4, 2021

agones-bot commented Nov 5, 2021

agones-bot commented Nov 5, 2021

agones-bot commented Nov 8, 2021

agones-bot commented Nov 8, 2021

agones-bot commented Nov 9, 2021

agones-bot commented Nov 11, 2021

agones-bot commented Nov 12, 2021

agones-bot commented Nov 12, 2021

roberthbailey commented Nov 12, 2021

agones-bot commented Nov 12, 2021

agones-bot commented Nov 12, 2021

markmandel commented Nov 12, 2021

markmandel left a comment

google-oss-prow bot commented Nov 12, 2021

agones-bot commented Nov 12, 2021

markmandel commented Nov 12, 2021

agones-bot commented Nov 12, 2021

SDKWatchSendOnExecute to Stable #2353

SDKWatchSendOnExecute to Stable #2353

Conversation

SaitejaTamma commented Oct 30, 2021

google-oss-robot commented Oct 30, 2021

agones-bot commented Oct 30, 2021

agones-bot commented Nov 1, 2021

roberthbailey commented Nov 3, 2021

agones-bot commented Nov 4, 2021

agones-bot commented Nov 5, 2021

agones-bot commented Nov 5, 2021

agones-bot commented Nov 8, 2021

agones-bot commented Nov 8, 2021

agones-bot commented Nov 9, 2021

agones-bot commented Nov 11, 2021

agones-bot commented Nov 12, 2021

agones-bot commented Nov 12, 2021

roberthbailey commented Nov 12, 2021

agones-bot commented Nov 12, 2021

agones-bot commented Nov 12, 2021

markmandel commented Nov 12, 2021

markmandel left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Nov 12, 2021

agones-bot commented Nov 12, 2021

markmandel commented Nov 12, 2021

agones-bot commented Nov 12, 2021