Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade client-go to v0.20.9. #2194

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Upgrade client-go to v0.20.9. #2194

merged 1 commit into from
Jul 27, 2021

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it: Update client-go to support Kubernets 1.20.0

Which issue(s) this PR fixes:

Work on #2186

Special notes for your reviewer:

I did a bit of local testing, but want to see this run through the cloudbuild e2es to make sure I haven't messed up something silly.

@roberthbailey roberthbailey added the kind/breaking Breaking change label Jul 23, 2021
@google-cla google-cla bot added the cla: yes label Jul 23, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2159ac85-f1bc-4f37-af6f-32817d0c828d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2194/head:pr_2194 && git checkout pr_2194
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-f38fcda

@roberthbailey roberthbailey added this to the 1.17.0 milestone Jul 24, 2021
markmandel
markmandel approved these changes Jul 27, 2021
View reviewed changes
go.mod
golang.org/x/tools v0.0.0-20210106214847-113979e3529a
google.golang.org/genproto v0.0.0-20200526211855-cb27e3aa2013
google.golang.org/grpc v1.27.0
google.golang.org/grpc v1.27.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought (non-blocking): We really should upgrade the SDK grpc versions 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created #2196 for the golang SDK. We should create ones for the others that need it (e.g. rust was just updated, so probably doesn't).

@markmandel markmandel merged commit b59615b into googleforgames:main Jul 27, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added the kind/feature New features for Agones label Jul 27, 2021
@roberthbailey roberthbailey deleted the client-go-1.20 branch September 23, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees

@markmandel markmandel

Labels
approved cla: yes kind/breaking Breaking change kind/feature New features for Agones lgtm size/XXL
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@roberthbailey @agones-bot @google-oss-robot @markmandel