Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shutdown problems in ping application. #2141

Merged
merged 5 commits into from
Jun 23, 2021
Merged

Fix shutdown problems in ping application. #2141

merged 5 commits into from
Jun 23, 2021

Conversation

s-shin
Copy link
Contributor

@s-shin s-shin commented Jun 18, 2021 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / Why we need it:

  • Make sure HTTP server gracefully shuts down.
    • Since ListenAndServe() always returns a non-nil error, the application exited by logger.Fatal() before graceful shutdown process is completed.
  • Remove unnecessary error log.
    • In shutdown process of udpServer, an error log was always emitted, but it's not actually an error in intentional shutdown triggered by signal.

Which issue(s) this PR fixes:

None maybe.

Special notes for your reviewer:

N/A

@s-shin
Fix shutdown problems in ping application.
fd9b79b 
* Make sure HTTP server gracefully shuts down.
    * Since ListenAndServe() always returns a non-nil error, the application
      exited by logger.Fatal() before graceful shutdown process is completed.
* Remove unnecessary error log.
    * In shutdown process of udpServer, an error log was always emitted, but
      it's not an error in intentional shutdown triggered by signal.
@google-cla google-cla bot added the cla: yes label Jun 18, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1442e879-c381-494e-ba8b-84cb353c01ba

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2141/head:pr_2141 && git checkout pr_2141
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-fd9b79b

markmandel
markmandel reviewed Jun 21, 2021
View reviewed changes
cmd/ping/main.go Outdated Show resolved Hide resolved
s-shin
s-shin commented Jun 22, 2021
View reviewed changes
cmd/ping/udp.go Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 33f4c460-38ba-45db-abca-069d73fc78ae

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2141/head:pr_2141 && git checkout pr_2141
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-0c45c47

@s-shin s-shin force-pushed the fix_shutdown_problem_in_ping_service branch from 0c45c47 to 8f05962 Compare June 22, 2021 11:06
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 11cd3d06-8519-49e8-8b6c-b8399c411892

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey roberthbailey self-assigned this Jun 22, 2021
@markmandel
Copy link
Member 

Copying file://agonessdk-server-1.16.0-8f05962.zip [Content-Type=application/zip]...
ResumableUploadAbortException: Upload complete with 1536 additional bytes left in stream; this can happen if a file changes size while being uploaded
CommandException: 1 file/object could not be transferred.
/ [0/1 files][    0.0 B/125.4 MiB]   0% Done

Hmnn, that happened again 🤔

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 86906f86-bd56-4705-8e36-bfded9cfdc7e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2141/head:pr_2141 && git checkout pr_2141
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-b1d5c49

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5e5f0cd5-d47e-4711-b4de-df441ac4660a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

This failed due to upgrading the e2e cluster to 1.19: Error from server (NotFound): statefulsets.apps "consul" not found

It needs to be updated to the main branch, which will cause the tests to re-run (with the proper stateful set name).

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, s-shin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7efd6604-7150-4770-8a28-bfd112f36d0d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2141/head:pr_2141 && git checkout pr_2141
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-dd858ec

@markmandel markmandel merged commit 2ad1ec8 into googleforgames:main Jun 23, 2021
@markmandel markmandel added the kind/bug These are bugs. label Jun 23, 2021
@roberthbailey roberthbailey added this to the 1.16.0 milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey left review comments

@markmandel markmandel markmandel approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@markmandel markmandel

@roberthbailey roberthbailey

Labels
approved cla: yes kind/bug These are bugs. size/M
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@s-shin @agones-bot @markmandel @roberthbailey @google-oss-robot @aLekSer