Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Afterverse logo #2092

Merged
merged 2 commits into from
May 6, 2021
Merged

Conversation

jose-cieni-afterverse
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / Why we need it:
Adds Afterverse logo to Companies that use Agones

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
I set the width to 120px, as our logo is smaller in height.
If this is a problem, let me know and I'll change it back to 100px.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2d2d14d5-fee5-41f4-a8e1-dcb8cc548118

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2092/head:pr_2092 && git checkout pr_2092
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-6169532

@markmandel
Copy link
Member

Oooh! Thanks!

🤔 I'm thinking it would best to be 100px, just because fairness.

I did some developer tools editing, and I think it looks fine at 100px. WDYT?

image

(We have a few other wide logos, and they are 100px, so probably be good to stick to things)

Unless you have a vertical lockup you want to use? I see you use the AV icon on a couple of places. Just a thought - but entirely up to you!

@jose-cieni-afterverse
Copy link
Contributor Author

@markmandel I think we're only using the AV logo for profile icons, but I'm not sure... no worries though, we'll just change it back to 100px 😄 Thank you!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: cc4138e7-24f7-4153-a46f-2f462dd171c0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2092/head:pr_2092 && git checkout pr_2092
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-5381d2c

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jose-cieni-playkids, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit c0d69e5 into googleforgames:main May 6, 2021
@markmandel markmandel added this to the 1.15.0 milestone May 6, 2021
@sawagh sawagh added kind/documentation Documentation for Agones area/site The website itself - including redirects, styling, search, etc labels Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/site The website itself - including redirects, styling, search, etc cla: yes kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants