Minor updates to the release checklist. #2080

roberthbailey · 2021-04-28T06:33:22Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

agones-bot · 2021-04-28T06:59:25Z

Build Succeeded 👏

Build Id: 994e2f1b-9f3c-460f-97b8-6ece5bea23dc

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.14.0-bdd73ba
image: gcr.io/agones-images/agones-ping:1.14.0-bdd73ba
Linux C++ SDK (build): agonessdk-1.14.0-bdd73ba-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.14.0-bdd73ba.zip

A preview of the website (the last 30 builds are retained):

https://bdd73ba-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2080/head:pr_2080 && git checkout pr_2080
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-bdd73ba

docs/governance/templates/release_issue.md

steven-supersolid · 2021-04-28T15:31:40Z

docs/governance/templates/release_issue.md

@@ -79,7 +78,7 @@ and copy it into a release issue. Fill in relevant values, found inside {}
 - [ ] If full release move [helm `tag` value][values] is set to {version}+1-dev
 - [ ] If full release move the [helm `Chart` version values][chart] is to {version}+1-dev
 - [ ] If full release move the [`sdks/nodejs/package.json`][nodejs] to {version}+1-dev


Suggested change

- [ ] If full release move the [`sdks/nodejs/package.json`][nodejs] to {version}+1-dev

- [ ] If full release, change to the `sdks/nodejs` directory and run the command `npm version preminor --preid=dev` to update the package version

markmandel · 2021-04-30T01:27:23Z

Changes LGTM! @roberthbailey do we want to include @steven-supersolid 's suggestions here?

roberthbailey · 2021-05-31T15:06:11Z

@roberthbailey do we want to include @steven-supersolid 's suggestions here?

I've tinkered with the npm version command a bit and I can't figure out how to get it to generate version strings that match what we have been doing by hand. I think it makes sense to merge this without that change (so that the typos get fixed) and then open a separate PR to apply @steven-supersolid's suggestions.

agones-bot · 2021-05-31T15:32:50Z

Build Succeeded 👏

Build Id: 7b277f7a-dd50-48db-8075-8b8b2e7d5992

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.15.0-86c3884
image: gcr.io/agones-images/agones-ping:1.15.0-86c3884
Linux C++ SDK (build): agonessdk-1.15.0-86c3884-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.15.0-86c3884.zip

A preview of the website (the last 30 builds are retained):

https://86c3884-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2080/head:pr_2080 && git checkout pr_2080
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-86c3884

agones-bot · 2021-06-01T02:52:15Z

Build Succeeded 👏

Build Id: 0431046e-0981-4360-8923-4419715c8c46

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.15.0-64ff605
image: gcr.io/agones-images/agones-ping:1.15.0-64ff605
Linux C++ SDK (build): agonessdk-1.15.0-64ff605-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.15.0-64ff605.zip

A preview of the website (the last 30 builds are retained):

https://64ff605-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2080/head:pr_2080 && git checkout pr_2080
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-64ff605

google-oss-robot · 2021-06-01T17:20:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2021-06-01T17:20:23Z

New changes are detected. LGTM label has been removed.

agones-bot · 2021-06-01T17:55:34Z

Build Succeeded 👏

Build Id: 15064a53-9a81-49a9-9a3c-ee894dc1fa66

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.15.0-4f61693
image: gcr.io/agones-images/agones-ping:1.15.0-4f61693
Linux C++ SDK (build): agonessdk-1.15.0-4f61693-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.15.0-4f61693.zip

A preview of the website (the last 30 builds are retained):

https://4f61693-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2080/head:pr_2080 && git checkout pr_2080
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-4f61693

roberthbailey added the kind/cleanup Refactoring code, fixing up documentation, etc label Apr 28, 2021

roberthbailey added this to the 1.15.0 milestone Apr 28, 2021

google-oss-robot requested review from aLekSer and cyriltovena April 28, 2021 06:33

google-cla bot added the cla: yes label Apr 28, 2021

google-oss-robot added approved size/XS labels Apr 28, 2021

markmandel mentioned this pull request Apr 28, 2021

Prep for the 1.15.0 release. #2079

Merged

steven-supersolid reviewed Apr 28, 2021

View reviewed changes

docs/governance/templates/release_issue.md Show resolved Hide resolved

steven-supersolid reviewed Apr 28, 2021

View reviewed changes

roberthbailey force-pushed the release-template branch from bdd73ba to 86c3884 Compare May 31, 2021 15:06

Minor updates to the release checklist.

64ff605

roberthbailey force-pushed the release-template branch from 86c3884 to 64ff605 Compare June 1, 2021 02:16

markmandel approved these changes Jun 1, 2021

View reviewed changes

google-oss-robot assigned markmandel Jun 1, 2021

google-oss-robot added the lgtm label Jun 1, 2021

Merge branch 'main' into release-template

4f61693

google-oss-robot removed the lgtm label Jun 1, 2021

markmandel merged commit c7f615c into googleforgames:main Jun 1, 2021

roberthbailey mentioned this pull request Jun 1, 2021

Change the way we generate new version numbers for nodejs #2120

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minor updates to the release checklist. #2080

Minor updates to the release checklist. #2080

roberthbailey commented Apr 28, 2021

agones-bot commented Apr 28, 2021

steven-supersolid Apr 28, 2021

markmandel commented Apr 30, 2021

roberthbailey commented May 31, 2021

agones-bot commented May 31, 2021

agones-bot commented Jun 1, 2021

google-oss-robot commented Jun 1, 2021

google-oss-robot commented Jun 1, 2021

agones-bot commented Jun 1, 2021

	- [ ] If full release move the [`sdks/nodejs/package.json`][nodejs] to {version}+1-dev
	- [ ] If full release, change to the `sdks/nodejs` directory and run the command `npm version preminor --preid=dev` to update the package version

Minor updates to the release checklist. #2080

Minor updates to the release checklist. #2080

Conversation

roberthbailey commented Apr 28, 2021

agones-bot commented Apr 28, 2021

steven-supersolid Apr 28, 2021

Choose a reason for hiding this comment

markmandel commented Apr 30, 2021

roberthbailey commented May 31, 2021

agones-bot commented May 31, 2021

agones-bot commented Jun 1, 2021

google-oss-robot commented Jun 1, 2021

google-oss-robot commented Jun 1, 2021

agones-bot commented Jun 1, 2021