Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the simple game server image to 0.3. #2048

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

roberthbailey
Copy link
Member

This is the first multi-arch build of the simple game server example,
which will run on both linux and windows.

Note that this change does not include the website, which will be done
in a follow up commit.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it: Part of #54

Special notes for your reviewer:

This is the first multi-arch build of the simple game server example,
which will run on both linux and windows.

Note that this change does not include the website, which will be done
in a follow up commit.
@roberthbailey
Copy link
Member Author

/cc @jeremyje
/assign @ilkercelikyilmaz

I haven't pushed the image to gcr.io/agones-images yet, but I pushed it to my project and verified that I can create a fleet with it.

@google-oss-robot
Copy link

@roberthbailey: GitHub didn't allow me to request PR reviews from the following users: jeremyje.

Note that only googleforgames members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jeremyje
/assign @ilkercelikyilmaz

I haven't pushed the image to gcr.io/agones-images yet, but I pushed it to my project and verified that I can create a fleet with it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roberthbailey
Copy link
Member Author

I just realized that the tests are all going to fail until I push the image, so I've gone ahead and pushed it.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1aa87d6b-7d9e-4384-85db-189e1cf3ea84

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2048/head:pr_2048 && git checkout pr_2048
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-73cc966

@roberthbailey
Copy link
Member Author

/assign @pooneh-m

@pooneh-m pooneh-m merged commit e3e016d into googleforgames:main Apr 5, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added this to the 1.14.0 milestone Apr 15, 2021
@roberthbailey roberthbailey added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/feature New features for Agones lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants