Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data race in sdkserver.go #1965

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Recent new tests found an intermittent data race in sdkserver.go

This fixed it 👍

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Recent new tests found an intermittent data race in sdkserver.go

This fixed it 👍
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2c510a6b-ea63-4b00-880a-e59d3a1f4c68

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1965/head:pr_1965 && git checkout pr_1965
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-443edd3

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 17bb461 into googleforgames:master Jan 26, 2021
@markmandel markmandel added this to the 1.12.0 milestone Jan 26, 2021
@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc and removed area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jan 26, 2021
@markmandel markmandel deleted the race/sdkserver branch February 4, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/bug These are bugs. lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants