Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "why" section for the Allocator Service documentation #1953

Merged
merged 2 commits into from
Jan 16, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

We get questions about which tool to use when allocating a GameServer - so here are some docs to help answer that question!

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

We get questions about which tool to use when allocating a GameServer -
so here are some docs to help answer that question!
@markmandel
Copy link
Member Author

@pooneh-m would particularly like your input here, see if I missed anything.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 959c2d60-3847-4ad4-b670-b0678c89ff1d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ae68374e-94e4-4dc0-82b8-5f42cf9b1af8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1953/head:pr_1953 && git checkout pr_1953
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-11865aa

Copy link
Contributor

@pooneh-m pooneh-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition! It is useful.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 28369a46-64ce-4b5d-807e-5301b817c27d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 51e98088-2254-4b92-989f-45b90cc86454

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1953/head:pr_1953 && git checkout pr_1953
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-c3f5217

@pooneh-m pooneh-m merged commit 8f439f0 into googleforgames:master Jan 16, 2021
@markmandel markmandel deleted the docs/why-allocator-service branch January 16, 2021 00:22
@markmandel markmandel added this to the 1.12.0 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/documentation Documentation for Agones kind/feature New features for Agones size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants