Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation to note there is no GameServer update support #1935

Merged
merged 9 commits into from
Jan 13, 2021
Merged

Update documentation to note there is no GameServer update support #1935

merged 9 commits into from
Jan 13, 2021

Conversation

yeslayla
Copy link
Contributor

@yeslayla yeslayla commented Dec 17, 2020 •
edited
Loading

What type of PR is this?
/kind documentation

What this PR does / Why we need it:

Updates the GameServer reference page to note the lack of update support.

This is the included message:

Please note that the GameServer resource does not support updates. If you need to make regular updates to the GameServer spec, consider using a [Fleet]({{< ref "/docs/Reference/fleet.md" >}}).

This change is due to people not being able to update GameServers and suspecting a bug.

Which issue(s) this PR fixes:
Closes #1724

Special notes for your reviewer:
If there is a better place for this, let me know. The reference page is what made most sense to me.

@google-cla google-cla bot added the cla: yes label Dec 17, 2020
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 92889f36-6220-43c2-8e6f-44c0e35b475a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e09e1094-bc17-4940-8f92-ea5a6855e302

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1935/head:pr_1935 && git checkout pr_1935
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-061e81b

@roberthbailey
Copy link
Member

@josephbmanley - this is great, thanks!

What do you think about wrapping this new text in a tip (e.g. https://agones.dev/site/docs/installation/install-agones/helm/#helm-test) or note (e.g. https://agones.dev/site/docs/installation/terraform/#prerequisites) block to make it stand out a bit more?

@yeslayla
Copy link
Contributor Author

@josephbmanley - this is great, thanks!

What do you think about wrapping this new text in a tip (e.g. https://agones.dev/site/docs/installation/install-agones/helm/#helm-test) or note (e.g. https://agones.dev/site/docs/installation/terraform/#prerequisites) block to make it stand out a bit more?

Sure, I'll go ahead and update this PR to include it as a note by the end of the day. 😄

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: dc70f1ce-487e-4892-8bf5-9ef31219aaf2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1d1aa618-95e1-44f1-b3d4-62ea16cd897f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1935/head:pr_1935 && git checkout pr_1935
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-e785301

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7b73a04e-1d82-4105-aee4-03fac942dcd4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1935/head:pr_1935 && git checkout pr_1935
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-65bb36b

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9cdb0fb1-993a-4282-bd92-e193da1eec4f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1935/head:pr_1935 && git checkout pr_1935
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-47c8938

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Jan 12, 2021
@yeslayla @markmandel
Update site/content/en/docs/Reference/gameserver.md
3eaffd7 
Co-authored-by: Mark Mandel <markmandel@google.com>
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fd928b81-7a34-4e0e-8758-49dcce68672a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1935/head:pr_1935 && git checkout pr_1935
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-3eaffd7

markmandel
markmandel approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephbmanley, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f52e2618-ac5b-49b8-8225-092131076b5d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1935/head:pr_1935 && git checkout pr_1935
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-5874156

@markmandel markmandel merged commit 7a4d1bc into googleforgames:master Jan 13, 2021
@markmandel markmandel added this to the 1.12.0 milestone Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@markmandel markmandel

Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/XS
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Documentation: GameServer updates are not supported. No pods are created after switching image for GameServer
5 participants
@yeslayla @agones-bot @roberthbailey @google-oss-robot @markmandel