Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the postcss-cli version #1930

Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This fixes a break in CI. postcss-cli@8.3.1 broke something in hugo, so we'll pin the version, which fixes things and allows CI to run again! 🙌

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

This fixes a break in CI. postcss-cli@8.3.1 broke something in hugo, so
we'll pin the version, which fixes things and allows CI to run again! 🙌
@markmandel markmandel added kind/bug These are bugs. area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/site The website itself - including redirects, styling, search, etc labels Dec 15, 2020
@markmandel markmandel added this to the 1.11.0 milestone Dec 15, 2020
@google-cla google-cla bot added the cla: yes label Dec 15, 2020
@markmandel markmandel requested review from aLekSer, pooneh-m and roberthbailey and removed request for cyriltovena and EricFortin December 15, 2020 17:18
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7ca70dbc-35c0-4c9c-afc6-0d6b65d980cf

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1930/head:pr_1930 && git checkout pr_1930
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-8c05616

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 0c3bb3a into googleforgames:master Dec 15, 2020
@markmandel markmandel deleted the build/pin-postcss-cli branch December 15, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/site The website itself - including redirects, styling, search, etc cla: yes kind/bug These are bugs. lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants