Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Kind dev tooling to 1.17.3 #1915

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Update Kind dev tooling to 1.17.3 #1915

merged 1 commit into from
Dec 8, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Updates to the next K8s verison.

Which issue(s) this PR fixes:

Work on #1824

Special notes for your reviewer:

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Dec 7, 2020
@google-cla google-cla bot added the cla: yes label Dec 7, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 154fc97b-cb80-4adc-a224-bbcee524c138

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1915/head:pr_1915 && git checkout pr_1915
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-6eae1cb

roberthbailey
roberthbailey reviewed Dec 8, 2020
View reviewed changes
build/includes/kind.mk Outdated
@@ -26,7 +26,7 @@ kind-test-cluster: DOCKER_RUN_ARGS+=--network=host
kind-test-cluster: $(ensure-build-image)
@if [ -z $$(kind get clusters | grep $(KIND_PROFILE)) ]; then\
echo "Could not find $(KIND_PROFILE) cluster. Creating...";\
kind create cluster --name $(KIND_PROFILE) --image kindest/node:v1.16.9 --wait 5m;\
kind create cluster --name $(KIND_PROFILE) --image kindest/node:v1.17.13 --wait 5m;\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you verify that this works? On https://hub.docker.com/r/kindest/node/tags?page=1&ordering=last_updated I see 1.17.11 but not 1.17.13.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't, I don't have Kind installed. Honestly, I've no idea if the dev tooling works. Maybe we should remove it entirely.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with removing it. If anyone is using it it would be straightforward to add back in (and then we would know who to get help from to keep it maintained).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I've installed Kind (that was actually really easy) - let's see if this thing works!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch to the 1.17.13 and ran through the tooling - all works!

@roberthbailey roberthbailey self-assigned this Dec 8, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7e7e9651-a3eb-472e-ba19-53190033c0bb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1915/head:pr_1915 && git checkout pr_1915
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-18a98c1

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 69bf2d4 into googleforgames:master Dec 8, 2020
@markmandel markmandel deleted the cleanup/kind-dev-1.17 branch December 8, 2020 21:12
@markmandel markmandel added this to the 1.11.0 milestone Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@roberthbailey roberthbailey

Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey