Add log level setting in allocator #1880

8398a7 · 2020-10-30T15:17:17Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:
When the number of requests is high, most of the logs become noise.
I wanted to set the log level to error, so I put out this PR.

Which issue(s) this PR fixes:

Closes #1879

Special notes for your reviewer:

8398a7 · 2020-10-30T15:18:29Z

cmd/allocator/main.go

@@ -66,10 +67,19 @@ const (
 func main() {
 	conf := parseEnvFlags()

-	logger.WithField("version", pkg.Version).WithField("ctlConf", conf).
+	logger.WithField("version", pkg.Version).WithField("conf", conf).


I think it's a remnant of the controller.
I fixed it, but I'll put it back if it looks problematic.

Yeah, can we roll this back. Better to be consistent between each binary.

agones-bot · 2020-10-30T15:28:50Z

Build Failed 😱

Build Id: fe4b00b2-d158-4f97-bc98-52a481681fb2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-10-30T16:01:36Z

Build Succeeded 👏

Build Id: 87865a47-4f1e-4555-886d-585070aa698c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.10.0-75cb93f
image: gcr.io/agones-images/agones-sdk:1.10.0-75cb93f
image: gcr.io/agones-images/agones-ping:1.10.0-75cb93f
Linux C++ SDK (build): agonessdk-1.10.0-75cb93f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.10.0-75cb93f.zip

A preview of the website (the last 30 builds are retained):

https://75cb93f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1880/head:pr_1880 && git checkout pr_1880
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-75cb93f

markmandel

This looks great - just that one small reversion, and this is good to go!

markmandel · 2020-11-02T19:19:28Z

cmd/allocator/main.go

@@ -66,10 +67,19 @@ const (
 func main() {
 	conf := parseEnvFlags()

-	logger.WithField("version", pkg.Version).WithField("ctlConf", conf).
+	logger.WithField("version", pkg.Version).WithField("conf", conf).


Yeah, can we roll this back. Better to be consistent between each binary.

8398a7 · 2020-11-03T00:15:16Z

Thank you. I put it back.

Better to be consistent between each binary.

Just out of curiosity, what are the benefits of consistency between binaries?

markmandel · 2020-11-03T00:32:12Z

Just out of curiosity, what are the benefits of consistency between binaries?

People know that they can find the same thing in each log, so there's no mystery on where to find them
If people are parsing the structured log format, there's no breaking changes there
Developers know what the standard is across the project, so there's less ambiguity.

8398a7 · 2020-11-03T00:37:28Z

It's certainly a break change.
I learned a lot about the others as well. Thank you.

agones-bot · 2020-11-03T00:37:37Z

Build Succeeded 👏

Build Id: 937661f0-4b72-4180-b4ab-266924fb60ef

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.10.0-4c70caf
image: gcr.io/agones-images/agones-sdk:1.10.0-4c70caf
image: gcr.io/agones-images/agones-ping:1.10.0-4c70caf
Linux C++ SDK (build): agonessdk-1.10.0-4c70caf-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.10.0-4c70caf.zip

A preview of the website (the last 30 builds are retained):

https://4c70caf-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1880/head:pr_1880 && git checkout pr_1880
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-4c70caf

agones-bot · 2020-11-03T00:42:58Z

Build Succeeded 👏

Build Id: ca7ddb29-2ed8-491b-8fdc-eb1d9e35dc44

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.10.0-ad56070
image: gcr.io/agones-images/agones-sdk:1.10.0-ad56070
image: gcr.io/agones-images/agones-ping:1.10.0-ad56070
Linux C++ SDK (build): agonessdk-1.10.0-ad56070-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.10.0-ad56070.zip

A preview of the website (the last 30 builds are retained):

https://ad56070-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1880/head:pr_1880 && git checkout pr_1880
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-ad56070

markmandel

Great stuff!

google-oss-robot · 2020-11-03T00:46:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 8398a7, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot requested review from cyriltovena and dzlier-gcp October 30, 2020 15:17

google-cla bot added the cla: yes label Oct 30, 2020

google-oss-robot added the size/S label Oct 30, 2020

8398a7 commented Oct 30, 2020

View reviewed changes

Add log level setting in allocator

75cb93f

8398a7 force-pushed the addAllocatorLogLevel branch from f51630d to 75cb93f Compare October 30, 2020 15:40

markmandel reviewed Nov 2, 2020

View reviewed changes

Roll back for consistency

ad56070

Merge branch 'master' into addAllocatorLogLevel

4c70caf

markmandel approved these changes Nov 3, 2020

View reviewed changes

google-oss-robot assigned markmandel Nov 3, 2020

google-oss-robot added lgtm approved labels Nov 3, 2020

markmandel merged commit beac12b into googleforgames:master Nov 3, 2020

markmandel added this to the 1.10.0 milestone Nov 3, 2020

8398a7 deleted the addAllocatorLogLevel branch November 3, 2020 00:48

markmandel added area/operations Installation, updating, metrics etc kind/feature New features for Agones labels Nov 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add log level setting in allocator #1880

Add log level setting in allocator #1880

8398a7 commented Oct 30, 2020

8398a7 Oct 30, 2020

markmandel Nov 2, 2020

agones-bot commented Oct 30, 2020

agones-bot commented Oct 30, 2020

markmandel left a comment

markmandel Nov 2, 2020

8398a7 commented Nov 3, 2020

markmandel commented Nov 3, 2020

8398a7 commented Nov 3, 2020

agones-bot commented Nov 3, 2020

agones-bot commented Nov 3, 2020

markmandel left a comment

google-oss-robot commented Nov 3, 2020

Add log level setting in allocator #1880

Add log level setting in allocator #1880

Conversation

8398a7 commented Oct 30, 2020

8398a7 Oct 30, 2020

Choose a reason for hiding this comment

markmandel Nov 2, 2020

Choose a reason for hiding this comment

agones-bot commented Oct 30, 2020

agones-bot commented Oct 30, 2020

markmandel left a comment

Choose a reason for hiding this comment

markmandel Nov 2, 2020

Choose a reason for hiding this comment

8398a7 commented Nov 3, 2020

markmandel commented Nov 3, 2020

8398a7 commented Nov 3, 2020

agones-bot commented Nov 3, 2020

agones-bot commented Nov 3, 2020

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Nov 3, 2020