Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add troubleshooting for allocation gRPC request #1878

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Add troubleshooting for allocation gRPC request #1878

merged 2 commits into from
Nov 3, 2020

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Oct 30, 2020 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind documentation

What this PR does / Why we need it:

Adding troubleshooting for allocation gRPC service, agones-allocator and some details on secrets for the service.
allocator-client.default is used in the example to simplify client setup for allocation.

Also adding troubleshooting for multicluster allocation.

Which issue(s) this PR fixes:

Closes #1866

Special notes for your reviewer:

@google-cla google-cla bot added the cla: yes label Oct 30, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bfdc5158-5db6-4d81-9a3b-0ab849992dc6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1878/head:pr_1878 && git checkout pr_1878
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-bd0868b

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ccfa6025-2efc-4768-8dc0-080244e0b162

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1878/head:pr_1878 && git checkout pr_1878
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-121d9e9

markmandel
markmandel reviewed Nov 2, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I had some minor bash fixups, but this this'll be great to get in!

site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/allocator-service.md Show resolved Hide resolved
site/content/en/docs/Advanced/allocator-service.md Show resolved Hide resolved
site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/multi-cluster-allocation.md Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/multi-cluster-allocation.md Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/multi-cluster-allocation.md Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 49b363c1-8fa2-4295-a05a-2bab69b43c3a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1878/head:pr_1878 && git checkout pr_1878
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-534de5a

markmandel
markmandel reviewed Nov 2, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @roberthbailey did you want to do a double check?

roberthbailey
roberthbailey reviewed Nov 2, 2020
View reviewed changes
site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved
@pooneh-m pooneh-m requested review from roberthbailey and removed request for cyriltovena November 2, 2020 23:55
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b5042836-b41f-4b34-b2ad-3d90013d4e8b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 66a9647b-c569-481f-8ce4-0c4eedbf6d5c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1878/head:pr_1878 && git checkout pr_1878
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-10351f4

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4dc44769-f788-4f76-b930-d629408f3c75

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1878/head:pr_1878 && git checkout pr_1878
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-115ffd9

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 55ac3660-8426-405d-8175-0babcf2e0d6a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1878/head:pr_1878 && git checkout pr_1878
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-da5ce24

@roberthbailey roberthbailey merged commit ac2dfe4 into googleforgames:master Nov 3, 2020
@markmandel markmandel added this to the 1.10.0 milestone Nov 3, 2020
@markmandel markmandel added kind/documentation Documentation for Agones kind/feature New features for Agones labels Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel left review comments

@roberthbailey roberthbailey roberthbailey approved these changes

Assignees

@roberthbailey roberthbailey

Labels
approved cla: yes kind/documentation Documentation for Agones kind/feature New features for Agones lgtm size/L
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

Add troubleshooting section to allocator and multicluster allocation
5 participants
@pooneh-m @agones-bot @google-oss-robot @markmandel @roberthbailey