Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built tools: Update install with Allocation certs #1869

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Built tools: Update install with Allocation certs #1869

merged 1 commit into from
Oct 27, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Add update-allocation-certs to the development tooling to be run after make install to provide a target to generate and store certificates for the Allocation gRPC endpoint.

Which issue(s) this PR fixes:

Related to #1852 and PR #1867

Special notes for your reviewer:

Primarily written so as to make testing with #1867 easier.

@markmandel markmandel added kind/feature New features for Agones area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Oct 27, 2020
@google-cla google-cla bot added the cla: yes label Oct 27, 2020
@markmandel markmandel requested review from pooneh-m and removed request for cyriltovena and dzlier-gcp October 27, 2020 01:42
@markmandel
Copy link
Member Author

/cc @ilkercelikyilmaz FYI

@google-oss-robot
Copy link

@markmandel: GitHub didn't allow me to request PR reviews from the following users: FYI.

Note that only googleforgames members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ilkercelikyilmaz FYI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markmandel
Built tools: Update install with Allocation certs
17a81fa 
Add `update-allocation-certs` to the development tooling to be run after
`make install` to provide a target to generate and store certificates
for the Allocation gRPC endpoint.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c4904a0c-a078-4df4-8828-fbd998a611d9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1869/head:pr_1869 && git checkout pr_1869
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-17a81fa

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a9fa0dc6-e7e5-4f68-a6a3-e7ead6184454

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1869/head:pr_1869 && git checkout pr_1869
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-c8048e8

@pooneh-m
Copy link
Contributor

Thanks, I like it :)

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit 241a91a into googleforgames:master Oct 27, 2020
@markmandel markmandel deleted the build/allocation-certs branch October 27, 2020 16:23
@markmandel markmandel added this to the 1.10.0 milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooneh-m pooneh-m pooneh-m approved these changes

@ilkercelikyilmaz ilkercelikyilmaz Awaiting requested review from ilkercelikyilmaz

Assignees

@pooneh-m pooneh-m

Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. cla: yes kind/feature New features for Agones lgtm size/S
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @google-oss-robot @agones-bot @pooneh-m