Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 in AWS/EKS documentation #1820

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
404 was breaking CI.

I found the medium version of the same article 🤷 weird, but good for us.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

Unclog's CI.

I found the medium version of the same article 🤷 weird, but good for
us.

Unclog's CI.
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aLekSer,markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a9f6d702-71ad-49c0-b661-5bc5efab3429

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1820/head:pr_1820 && git checkout pr_1820
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-96e7ae7

@markmandel markmandel merged commit 507da4f into googleforgames:master Sep 16, 2020
@markmandel markmandel added this to the 1.9.0 milestone Sep 16, 2020
@markmandel markmandel deleted the docs/404-eks branch September 16, 2020 16:50
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
I found the medium version of the same article 🤷 weird, but good for
us.

Unclog's CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants