Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load balancer configuration for Helm options #1793

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

yoshd
Copy link
Contributor

@yoshd yoshd commented Sep 4, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Added the following Helm configuration options:

  • agones.allocator.http.loadBalancerSourceRanges
  • agones.ping.http.loadBalancerIP
  • agones.ping.http.loadBalancerSourceRanges
  • agones.ping.udp.loadBalancerIP
  • agones.ping.udp.loadBalancerSourceRanges

This allows the Helm installation to configure the LoadBalancer loadBalancerIP and loadBalancerSourceRanges.

@yoshd
Copy link
Contributor Author

yoshd commented Sep 4, 2020

/assign @EricFortin

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c7c2f1ee-b541-409c-8d1e-a8b79621f1a7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1793/head:pr_1793 && git checkout pr_1793
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-44712bd

@markmandel markmandel added area/operations Installation, updating, metrics etc kind/feature New features for Agones labels Sep 8, 2020
@pooneh-m
Copy link
Contributor

pooneh-m commented Sep 8, 2020

@yoshd is loadBalancerSourceRanges manually tested?

Copy link
Contributor

@pooneh-m pooneh-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EricFortin, pooneh-m, yoshd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [EricFortin,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a192372d-6a89-469d-98c6-d1afe78f020c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5e6a9638-371e-499a-902a-fc0cc1d95da5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fca68d97-ed49-45ca-ba37-1b4c6f51b242

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1793/head:pr_1793 && git checkout pr_1793
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-1b54086

@markmandel markmandel merged commit b90e22c into googleforgames:master Sep 8, 2020
@markmandel markmandel added this to the 1.9.0 milestone Sep 8, 2020
@yoshd
Copy link
Contributor Author

yoshd commented Sep 9, 2020

@pooneh-m
Thank you for checking.
I built a cluster with GKE and set each value when installing with helm.
I've confirmed that setting *.loadBalancerSourceRanges creates a firewall.
I also reserved a static IP address, set it to *.loadBalancerIP, and confirmed that the IP address is being used.

@yoshd yoshd deleted the helm-lb-config branch September 10, 2020 14:57
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc cla: yes kind/feature New features for Agones lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants