-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add load balancer configuration for Helm options #1793
Conversation
/assign @EricFortin |
Build Succeeded 👏 Build Id: c7c2f1ee-b541-409c-8d1e-a8b79621f1a7 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
@yoshd is loadBalancerSourceRanges manually tested? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EricFortin, pooneh-m, yoshd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Failed 😱 Build Id: a192372d-6a89-469d-98c6-d1afe78f020c To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 5e6a9638-371e-499a-902a-fc0cc1d95da5 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: fca68d97-ed49-45ca-ba37-1b4c6f51b242 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
@pooneh-m |
Co-authored-by: Mark Mandel <markmandel@google.com>
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Added the following Helm configuration options:
agones.allocator.http.loadBalancerSourceRanges
agones.ping.http.loadBalancerIP
agones.ping.http.loadBalancerSourceRanges
agones.ping.udp.loadBalancerIP
agones.ping.udp.loadBalancerSourceRanges
This allows the Helm installation to configure the LoadBalancer loadBalancerIP and loadBalancerSourceRanges.