Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish to NuGet for Csharp SDK #1753

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Publish to NuGet for Csharp SDK #1753

merged 2 commits into from
Aug 24, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Implements build tools and release process for publishing the SDK to Nuget.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Once the package is live, we can update the Csharp SDK documentation to
match (also, I shouldn't be the person to write it, as I'm only doing
this PR as I have access to all the accounts)

@markmandel markmandel added kind/feature New features for Agones area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Aug 14, 2020
@markmandel
Copy link
Member Author

@rcreasey @Reousa PTAL and let me know if this all looks good to you.

Also @Reousa , is it possible we can take over ownership of https://www.nuget.org/packages/AgonesSDK/ ?

@markmandel
Copy link
Member Author

@yoshd and @pooneh-m are also csharp people, so please also take a look! 👍

rcreasey
rcreasey approved these changes Aug 14, 2020
View reviewed changes
Copy link
Collaborator

@rcreasey rcreasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Exciting!

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 834e84d4-2ec5-43e0-9653-989a9f2d1dad

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 09d0e346-fef5-4296-9c15-a1cc743011dd

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Weird, I think the Rust SDK is failing suddeny?

@markmandel
Copy link
Member Author

Hmnn, Rust conformance test worked locally just fine. I am confused.

@markmandel
Copy link
Member Author

Aha! Replicated by deleting the Cargo.lock in test/rust

   Compiling polling v0.1.4
   Compiling parking_lot_core v0.7.2
   Compiling num_cpus v1.13.0
The following warnings were emitted during compilation:

warning: cc: error: src/zlib/adler32.c: No such file or directory
warning: cc: fatal error: no input files
warning: compilation terminated.

error: failed to run custom build command for `libz-sys v1.0.26`

Caused by:
  process didn't exit successfully: `/go/src/agones.dev/agones/test/sdk/rust/.cargo-targets/debug/build/libz-sys-b1dac8d828a38de1/build-script-build` (exit code: 1)
--- stdout
cargo:rerun-if-env-changed=LIBZ_SYS_STATIC
cargo:rerun-if-changed=build.rs
TARGET = Some("x86_64-unknown-linux-gnu")
OPT_LEVEL = Some("0")
HOST = Some("x86_64-unknown-linux-gnu")
CC_x86_64-unknown-linux-gnu = None
CC_x86_64_unknown_linux_gnu = None
HOST_CC = None
CC = None
CFLAGS_x86_64-unknown-linux-gnu = None
CFLAGS_x86_64_unknown_linux_gnu = None
HOST_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
DEBUG = Some("true")
CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
running: "cc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-I" "src/zlib" "-fvisibility=hidden" "-DSTDC" "-D_LARGEFILE64_SOURCE" "-D_POSIX_SOURCE" "-o" "/go/src/agones.dev/agones/test/sdk/rust/.cargo-targets/debug/build/libz-sys-a02131f0a09b5ae6/out/build/src/zlib/adler32.o" "-c" "src/zlib/adler32.c"
cargo:warning=cc: error: src/zlib/adler32.c: No such file or directory
cargo:warning=cc: fatal error: no input files
cargo:warning=compilation terminated.
exit code: 1

--- stderr


error occurred: Command "cc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-I" "src/zlib" "-fvisibility=hidden" "-DSTDC" "-D_LARGEFILE64_SOURCE" "-D_POSIX_SOURCE" "-o" "/go/src/agones.dev/agones/test/sdk/rust/.cargo-targets/debug/build/libz-sys-a02131f0a09b5ae6/out/build/src/zlib/adler32.o" "-c" "src/zlib/adler32.c" with args "cc" did not execute successfully (status code exit code: 1).



warning: build failed, waiting for other jobs to finish...
error: build failed
make[1]: *** [includes/sdk.mk:88: run-sdk-command] Error 101

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4f846cf8-854e-4591-9544-8701f1de547a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

This is the bug!
rust-lang/libz-sys#65

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a660eed8-f00e-4d1d-ad35-9db4fe9c900a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1753/head:pr_1753 && git checkout pr_1753
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-3509c93

@yoshd
Copy link
Contributor

yoshd commented Aug 15, 2020

That's excellent!
I was just thinking I needed it.
Thank you!

@google-oss-robot
Copy link

@Reousa: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Reousa
Copy link
Contributor

Reousa commented Aug 15, 2020 •
edited
Loading

LGTM. @markmandel let me know which account to pass ownership to, will get it done asap!

Appologies I haven't been able to contribute my part recently, things have been hectic! 🙏

@markmandel markmandel marked this pull request as ready for review August 17, 2020 17:20
@markmandel
Copy link
Member Author

@Reousa the account is https://www.nuget.org/profiles/agones

Thanks so much! I'll get this published as soon as we make the switch over 👍

@markmandel
Copy link
Member Author

https://www.nuget.org/packages/AgonesSDK/1.8.0-rc

Is up, and validating!

Since I'm releasing 1.8.0 today, I will update this PR to 1.8.0 post release, but that means we will be able to get a 1.8.0 NuGet release out shortly after the stable Agones release.

@markmandel
Copy link
Member Author

Gentle bump to reviewer with approval permissions - can we get this in, and then I can publish the 1.8.0 NuGet package as well.

(and create a ticket to update the docs as well)

roberthbailey
roberthbailey reviewed Aug 24, 2020
View reviewed changes
sdks/csharp/sdk/csharp-sdk.csproj Outdated Show resolved Hide resolved
sdks/csharp/sdk/AgonesSDK.nuspec Outdated Show resolved Hide resolved
build/build-sdk-images/csharp/publish.sh Outdated Show resolved Hide resolved
docs/governance/templates/release_issue.md Outdated Show resolved Hide resolved
@markmandel
Publish to NuGet for Csharp SDK
a21fed1 
Implements build tools and release process for publishing the SDK to
Nuget.

Once the package is live, we can update the Csharp SDK documentation to
match (also, I shouldn't be the person to write it, as I'm only doing
this PR as I have access to all the accounts)
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f03bb0a2-208e-4432-a46b-f97c9fbf6598

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1753/head:pr_1753 && git checkout pr_1753
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-ac40072

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, rcreasey, Reousa, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: be710dca-f206-4c5b-a25b-70bc5ac5bd21

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1753/head:pr_1753 && git checkout pr_1753
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-e927fdc

@roberthbailey roberthbailey merged commit a872dcb into googleforgames:master Aug 24, 2020
@markmandel markmandel deleted the build/nuget-publish branch August 24, 2020 19:31
@markmandel markmandel mentioned this pull request Aug 24, 2020
Closed
@markmandel markmandel added this to the 1.9.0 milestone Sep 22, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Publish to NuGet for Csharp SDK (googleforgames#1753)
fa04ba3 
Implements build tools and release process for publishing the SDK to
Nuget.

Once the package is live, we can update the Csharp SDK documentation to
match (also, I shouldn't be the person to write it, as I'm only doing
this PR as I have access to all the accounts)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcreasey rcreasey rcreasey approved these changes

@roberthbailey roberthbailey roberthbailey approved these changes

@Reousa Reousa Reousa approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@rcreasey rcreasey

@roberthbailey roberthbailey

Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. cla: yes kind/feature New features for Agones lgtm size/M
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
8 participants
@markmandel @agones-bot @yoshd @google-oss-robot @Reousa @rcreasey @roberthbailey @googlebot