Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CloudBuild to N1_HIGHCPU_32 #1668

Merged
merged 5 commits into from
Jul 10, 2020
Merged

Move CloudBuild to N1_HIGHCPU_32 #1668

merged 5 commits into from
Jul 10, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Let's try a bigger box, see if that helps with things.

Which issue(s) this PR fixes:

None, just general flakiness and build times.

Special notes for your reviewer:

Let's see what the logs say / build times are like.

@markmandel
Move CloudBuild to N1_HIGHCPU_32
7a2d54d 
Let's try a bigger box, see if that helps with things.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jun 30, 2020
@markmandel
Copy link
Member Author 

--- FAIL: TestPerNodeCounterRun (0.33s)
    pernodecounter_test.go:189: 
        	Error Trace:	pernodecounter_test.go:189
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 2
        	Test:       	TestPerNodeCounterRun

Different flake!

@markmandel
Copy link
Member Author

Weird that it's stuck on status checks through.

@markmandel
Copy link
Member Author

Oh I know why there is no status - that's the cloud function that integrates with this system. I'll get onto that seperately.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a989f1b3-5f80-400a-9659-9f977d9a3a07

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Ooh, that's a new one. Lots of cores means that hugo sometimes falls over:

fatal error: concurrent map read and map write

Going to do a PR to update hugo and docsy then!

markmandel added a commit to markmandel/agones that referenced this pull request Jul 1, 2020
@markmandel
Update Hugo and Docsy
5ec0bff 
Due to googleforgames#1668, saw that Hugo can fall over with:
`fatal error: concurrent map read and map write`

When there are lots of CPUs, so decided it was time to take the
opportunity to update Hugo.

Only big difference was to enable "unsafe" in the markdown engine, so
that it would allow HTML in markdown.
@markmandel markmandel mentioned this pull request Jul 1, 2020
Merged
markmandel added a commit to markmandel/agones that referenced this pull request Jul 6, 2020
@markmandel
Update Hugo and Docsy
ed5e42c 
Due to googleforgames#1668, saw that Hugo can fall over with:
`fatal error: concurrent map read and map write`

When there are lots of CPUs, so decided it was time to take the
opportunity to update Hugo.

Only big difference was to enable "unsafe" in the markdown engine, so
that it would allow HTML in markdown.
markmandel added a commit that referenced this pull request Jul 6, 2020
@markmandel
Update Hugo and Docsy (#1671)
f3723b0 
Due to #1668, saw that Hugo can fall over with:
`fatal error: concurrent map read and map write`

When there are lots of CPUs, so decided it was time to take the
opportunity to update Hugo.

Only big difference was to enable "unsafe" in the markdown engine, so
that it would allow HTML in markdown.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 47198892-e944-4876-908c-87a45691af8e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1668/head:pr_1668 && git checkout pr_1668
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-fdaa324

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e96d4e42-4a4c-46e9-aabf-708537f58e14

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1668/head:pr_1668 && git checkout pr_1668
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-a1387ed

@markmandel
Copy link
Member Author

Ran in 17 minutes. Shaves off 3-5 minutes or so from the build time. Not bad!

@markmandel markmandel marked this pull request as ready for review July 9, 2020 21:30
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fd81f466-4cd7-4a2f-94d9-eed69ecd28df

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1668/head:pr_1668 && git checkout pr_1668
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-305135e

@roberthbailey roberthbailey merged commit a78a272 into googleforgames:master Jul 10, 2020
@markmandel markmandel deleted the ci/bigger-box branch July 10, 2020 15:17
@markmandel markmandel added this to the 1.8.0 milestone Jul 10, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Update Hugo and Docsy (googleforgames#1671)
84e7668 
Due to googleforgames#1668, saw that Hugo can fall over with:
`fatal error: concurrent map read and map write`

When there are lots of CPUs, so decided it was time to take the
opportunity to update Hugo.

Only big difference was to enable "unsafe" in the markdown engine, so
that it would allow HTML in markdown.
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @roberthbailey @ilkercelikyilmaz
Move CloudBuild to N1_HIGHCPU_32 (googleforgames#1668)
a028cc4 
Let's try a bigger box, see if that helps with things.

Co-authored-by: Robert Bailey <robertbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@roberthbailey roberthbailey

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey @googlebot