-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node.js dependencies in sdk and example #1657
Conversation
Build Failed 😱 Build Id: 14951c37-f779-4c14-babc-03748f0c477f To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
@@ -1,6 +1,6 @@ | |||
{ | |||
"dependencies": { | |||
"@google-cloud/agones-sdk": "1.5.0" | |||
"@google-cloud/agones-sdk": "1.6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth also incrementing the example version?
https://github.com/googleforgames/agones/blob/master/examples/nodejs-simple/Makefile#L31
Outside of that, this is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, steven-supersolid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I swear this only happens to you @steven-supersolid , it's so weird! |
Build Succeeded 👏 Build Id: c34673e9-aced-4ced-aab4-4aafabf46f6e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Would you mind rebasing to master, I've no idea why, but I can't hit the button, otherwise I would. |
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: c5305a48-8d3c-45fd-955b-45a261d16938 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
* update dependencies in sdk and example * Update nodejs-simple version to 0.5
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Update grpc-js dependency. Add required peer dependency google-auth-library
Update Nodejs example to use currently published SDK
Update & dedupe dependencies to reduce size
Special notes for your reviewer:
grpc-js has been update with some bug fixes