Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js dependencies in sdk and example #1657

Merged
merged 3 commits into from
Jun 29, 2020

Conversation

steven-supersolid
Copy link
Collaborator

What type of PR is this?
/kind cleanup

What this PR does / Why we need it:
Update grpc-js dependency. Add required peer dependency google-auth-library
Update Nodejs example to use currently published SDK
Update & dedupe dependencies to reduce size

Special notes for your reviewer:
grpc-js has been update with some bug fixes

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 14951c37-f779-4c14-babc-03748f0c477f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@steven-supersolid steven-supersolid changed the title update dependencies in sdk and example Update Node.js dependencies in sdk and example Jun 27, 2020
@@ -1,6 +1,6 @@
{
"dependencies": {
"@google-cloud/agones-sdk": "1.5.0"
"@google-cloud/agones-sdk": "1.6.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth also incrementing the example version?

https://github.com/googleforgames/agones/blob/master/examples/nodejs-simple/Makefile#L31

Outside of that, this is good to go.

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel
Copy link
Member

I swear this only happens to you @steven-supersolid , it's so weird!

image

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c34673e9-aced-4ced-aab4-4aafabf46f6e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1657/head:pr_1657 && git checkout pr_1657
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-1ad9116

@markmandel
Copy link
Member

Would you mind rebasing to master, I've no idea why, but I can't hit the button, otherwise I would.

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c5305a48-8d3c-45fd-955b-45a261d16938

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1657/head:pr_1657 && git checkout pr_1657
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-2e1d133

@markmandel markmandel merged commit b378628 into googleforgames:master Jun 29, 2020
@markmandel markmandel added area/examples Examples. Usually found in the `examples` directory area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc labels Jun 29, 2020
@markmandel markmandel added this to the 1.7.0 milestone Jun 29, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
* update dependencies in sdk and example
* Update nodejs-simple version to 0.5
@steven-supersolid steven-supersolid deleted the nodejs-deps branch October 25, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/examples Examples. Usually found in the `examples` directory area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants