Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky: Csharp SDK Test #1651

Merged
merged 3 commits into from
Jun 26, 2020
Merged

Flaky: Csharp SDK Test #1651

merged 3 commits into from
Jun 26, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Theory is that the Csharp SDK build is in a race condition with the test
system. So we'll try making tests dependent on build-sdks to see if that
solves the issue.

Which issue(s) this PR fixes:

Closes #1639

Special notes for your reviewer:
We should retry this build multiple times, to see if it actually works.

@markmandel
Flaky: Csharp SDK Test
55bd27c 
Theory is that the Csharp SDK build is in a race condition with the test
system. So we'll try making tests dependent on build-sdks to see if that
solves the issue.

Closes googleforgames#1639
@markmandel markmandel added kind/bug These are bugs. area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jun 25, 2020
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b32e40a9-fbb9-4879-9726-621277fd5ccb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Different flake, looks like the e2e cluster got full again, since the new namespace sometimes isn't cleaned up.

We probably need a script to clean up old namespaces at the beginning of tests.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2940c9ec-7610-4b22-bcdc-471783d51944

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1651/head:pr_1651 && git checkout pr_1651
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-55bd27c

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e590887b-2d15-40b5-834c-65e1a578d07d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1651/head:pr_1651 && git checkout pr_1651
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-f597ad7

@markmandel
Copy link
Member Author

Did this take ~10 minutes off the build time, somehow?

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bf04d09d-052e-420e-9abf-6fc31f5a153e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1651/head:pr_1651 && git checkout pr_1651
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-f597ad7

@markmandel
Copy link
Member Author

This is looking like it's working. Running one more time!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e810b08e-1f09-4626-987c-ed042557ea60

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1651/head:pr_1651 && git checkout pr_1651
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-f597ad7

@markmandel markmandel marked this pull request as ready for review June 25, 2020 22:29
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 76e2717e-3b79-4245-a477-0feacfd6a36b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1651/head:pr_1651 && git checkout pr_1651
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-b0341a2

aLekSer
aLekSer approved these changes Jun 26, 2020
View reviewed changes
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a true fix.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer merged commit 1292bb1 into googleforgames:master Jun 26, 2020
@markmandel markmandel deleted the flaky/test-csharp-build branch June 26, 2020 16:10
@markmandel markmandel added this to the 1.7.0 milestone Jun 30, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Flaky: Csharp SDK Test (googleforgames#1651)
f5d6cf8 
Theory is that the Csharp SDK build is in a race condition with the test
system. So we'll try making tests dependent on build-sdks to see if that
solves the issue.

Closes googleforgames#1639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aLekSer aLekSer aLekSer approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@aLekSer aLekSer

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/bug These are bugs. lgtm size/XS
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

C# SDK build is flakey due to a race condition
5 participants
@markmandel @agones-bot @google-oss-robot @aLekSer @googlebot