Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding parallel to more tests. #1602

Merged
merged 3 commits into from
Jun 2, 2020
Merged

Adding parallel to more tests. #1602

merged 3 commits into from
Jun 2, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Simple cleanup, found some unit tests that could run in parallel but
weren't.

Which issue(s) this PR fixes:

None.

Special notes for your reviewer:
None.

@markmandel
Adding parallel to more tests.
99ee59d 
Simple cleanup, found some unit tests that could run in parallel but
weren't.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jun 2, 2020
@markmandel markmandel requested a review from aLekSer June 2, 2020 00:02
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 34aed7d9-765a-4063-9574-b4e470b8f73e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e7b5ab33-ebfd-4f14-be9f-c5ca8b4baf95

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1602/head:pr_1602 && git checkout pr_1602
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-99ee59d

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: da79382e-c779-494f-bc64-b0b29a650e08

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6c72859e-ef2d-420a-97a5-e211c0e4a460

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1602/head:pr_1602 && git checkout pr_1602
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-3044762

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer merged commit 9f776bc into googleforgames:master Jun 2, 2020
@markmandel markmandel deleted the cleanup/more-parralel branch June 2, 2020 16:33
@markmandel markmandel added this to the 1.7.0 milestone Jun 30, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @aLekSer @ilkercelikyilmaz
Adding parallel to more tests. (googleforgames#1602)
959f932 
Simple cleanup, found some unit tests that could run in parallel but
weren't.

Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aLekSer aLekSer aLekSer approved these changes

@pooneh-m pooneh-m pooneh-m approved these changes

@EricFortin EricFortin Awaiting requested review from EricFortin

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@aLekSer aLekSer

@pooneh-m pooneh-m

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/S
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@markmandel @agones-bot @google-oss-robot @aLekSer @pooneh-m