Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional commands for prometheus and grafana #1601

Merged
merged 2 commits into from
Jun 3, 2020

Conversation

akremsa
Copy link
Contributor

@akremsa akremsa commented Jun 1, 2020

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:
While I was working on prometheus\grafana-related tasks I found that it would be nice to add some new commands inside a Makefile.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a0e907ab-4054-47e5-a18a-f14be3687b9e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1601/head:pr_1601 && git checkout pr_1601
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-9100471

build/Makefile Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7a4631e7-8b72-495f-aecc-240a0eac4eb2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Copy link
Collaborator

aLekSer commented Jun 3, 2020

Some E2E tests are failing due to change in consul lock name in #1611 . Previously it was LockE2E, now we need to have separate two locks, one per each E2E test cluster name.

@aLekSer
Copy link
Collaborator

aLekSer commented Jun 3, 2020

These two commands would be useful.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akremsa, aLekSer
To complete the pull request process, please assign cyriltovena
You can assign the PR to them by writing /assign @cyriltovena in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8e19a889-dc36-4012-8aeb-203fb80bd2e4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1601/head:pr_1601 && git checkout pr_1601
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-470ccaa

@aLekSer aLekSer merged commit f1dc53e into googleforgames:master Jun 3, 2020
@markmandel markmandel added this to the 1.7.0 milestone Jun 30, 2020
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/feature New features for Agones labels Jun 30, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
…es#1601)

Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/feature New features for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants