-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grafana - add namespace to distinguish fleets with the same name #1597
Grafana - add namespace to distinguish fleets with the same name #1597
Conversation
Build Succeeded 👏 Build Id: 2129b187-bffa-47b3-90ac-ad3996d5cbfa The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
125d78a
to
2d70180
Compare
Build Failed 😱 Build Id: 0632cba8-f1aa-47a0-af2b-a820dd86ff74 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
We need at some point to change this to jsonnet/grafonnet.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akremsa, cyriltovena The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: 7f9eea7c-495d-433c-b54f-3936952b8b40 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: e0dea350-1b2b-4de5-944d-1c00bdf6a32f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
…gleforgames#1597) Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
What type of PR is this?
What this PR does / Why we need it:
Fleet metrics from different namespaces are split.
Which issue(s) this PR fixes:
Closes #1501
Special notes for your reviewer: