Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana - add namespace to distinguish fleets with the same name #1597

Merged

Conversation

akremsa
Copy link
Contributor

@akremsa akremsa commented May 29, 2020

What type of PR is this?

/kind bug

What this PR does / Why we need it:
Fleet metrics from different namespaces are split.

Which issue(s) this PR fixes:
Closes #1501

Special notes for your reviewer:
image

image

image

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2129b187-bffa-47b3-90ac-ad3996d5cbfa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1597/head:pr_1597 && git checkout pr_1597
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-125d78a

@akremsa akremsa force-pushed the grafana-gameservers-dashboard branch from 125d78a to 2d70180 Compare June 1, 2020 11:36
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0632cba8-f1aa-47a0-af2b-a820dd86ff74

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

We need at some point to change this to jsonnet/grafonnet.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, cyriltovena

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7f9eea7c-495d-433c-b54f-3936952b8b40

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1597/head:pr_1597 && git checkout pr_1597
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-e24089d

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e0dea350-1b2b-4de5-944d-1c00bdf6a32f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1597/head:pr_1597 && git checkout pr_1597
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-8eea087

@cyriltovena cyriltovena merged commit 4402484 into googleforgames:master Jun 3, 2020
@markmandel markmandel added this to the 1.7.0 milestone Jun 30, 2020
@markmandel markmandel added area/operations Installation, updating, metrics etc kind/feature New features for Agones labels Jun 30, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc kind/feature New features for Agones size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics: add namespace to distinguish same name fleets
6 participants