-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update edit-first-gameserver-go.md #1595
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Build Failed 😱 Build Id: aef7e524-0828-4be4-ada8-6841afef937d To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
You can ignore this failure. I made some changes to the IAM permission in cloud build, and so it failed because of that. |
Apologies in advance - this looks like a good fix, you just going to get hit with errors on this PR as I adjust the IAM permissions. Thanks though! |
Build Failed 😱 Build Id: 1e16ebbd-e057-48c5-83c9-6bbfa4372604 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 5bcc3341-8da8-44d2-bf99-3509c59c4a87 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
site/content/en/docs/Getting Started/edit-first-gameserver-go.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark Mandel <markmandel@google.com>
Build Failed 😱 Build Id: a9193b3c-8d83-4de1-a2b0-ec00960b045c To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Got bit by a flaky test. Retrying. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, minho-comcom-ai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: bcdbab9a-41e5-4ca1-83f9-dfb7487cf97c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
* Update edit-first-gameserver-go.md * Update site/content/en/docs/Getting Started/edit-first-gameserver-go.md Co-authored-by: Mark Mandel <markmandel@google.com>
What type of PR is this?
/kind documentation
What this PR does / Why we need it: Add one link for
main.go
Which issue(s) this PR fixes:
Special notes for your reviewer: