Metrics: add namespace to distinguish fleets with the same name #1585

akremsa · 2020-05-26T15:39:12Z

What type of PR is this?

/kind bug

What this PR does / Why we need it:
Fleet metrics from different namespaces are split.

Which issue(s) this PR fixes:
Closes #1501

Special notes for your reviewer:

gameservers_count:

Prometheus:

agones-bot · 2020-05-26T15:51:31Z

Build Failed 😱

Build Id: 03f3f49d-a19b-4da2-985b-f640a185031c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2020-05-26T16:00:45Z

Seems that github breaks website check again:

for i in {1..5}; \
	do echo "Html Test: Attempt $i" && \
	  docker run --rm -t -e "TERM=xterm-256color" -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.helm:/root/.helm -v /workspace:/go/src/agones.dev/agones -v /workspace/build//.gomod:/go/pkg/mod -v /workspace/build//.gocache:/root/.cache/go-build  agones-build:ae232b533a bash -c \
		"mkdir -p /tmp/website && cp -r /go/src/agones.dev/agones/site/public /tmp/website/site && htmltest -c /go/src/agones.dev/agones/site/htmltest.yaml /tmp/website" && \
break || sleep 60; done
Html Test: Attempt {1..5}
...
 Non-OK status: 429 --- site/docs/installation/creating-cluster/aks/index.html --> https://github.com/dgkanatsios/AksNodePublicIPController
site/docs/installation/creating-cluster/minikube/index.html
  Non-OK status: 429 --- site/docs/installation/creating-cluster/minikube/index.html --> https://github.com/kubernetes/minikube#requirements
========================================================================
✘✘✘ failed in 45.759002885s
133 errors in 109 documents

And TestLocalSDKServerPlayerConnectAndDisconnect is flaky.

       localsdk_test.go:444: 
            	Error Trace:	localsdk_test.go:444
            	Error:      	Should be true
            	Test:       	TestLocalSDKServerPlayerConnectAndDisconnect/test_mode_on,_no_filePath
            	Messages:   	Player should not exist yet
        localsdk_test.go:448: 
            	Error Trace:	localsdk_test.go:448
            	Error:      	Not equal: 
            	            	expected: 1
            	            	actual  : 0
            	Test:       	TestLocalSDKServerPlayerConnectAndDisconnect/test_mode_on,_no_filePath
        localsdk_test.go:634: 
            	Error Trace:	localsdk_test.go:634
            	            				localsdk_test.go:455
            	Error:      	timeout on receiving messages
            	Test:       	TestLocalSDKServerPlayerConnectAndDisconnect/test_mode_on,_no_filePath

I am able to reproduce similar with go test -v -parallel 10

aLekSer · 2020-05-26T16:03:13Z

@akremsa Please include metrics/controller_test.go which is failing:


    controller_test.go:71: 
        	Error Trace:	controller_test.go:71
        	            				controller_test.go:250
        	Error:      	Should be true
        	Test:       	TestControllerFleetAutoScalerState
        	Messages:   	no TimeSeries found with labels: [first-fleet name-switch default]

markmandel · 2020-05-26T16:22:56Z

Html Test: Attempt {1..5}

It's so weird. Locally, it will do 5 retries (shell sees $i as 1, then 2 then 3, etc). On Cloud Build, it sees $i as {1..5} - I'm not sure why.

agones-bot · 2020-05-27T11:40:07Z

Build Failed 😱

Build Id: 84b5ce43-2807-4859-8553-4c192b89a69f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-05-27T11:43:27Z

Build Succeeded 👏

Build Id: d3d0c44c-357b-4c07-886c-cefd0911f693

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-4d502c0
image: gcr.io/agones-images/agones-sdk:1.6.0-4d502c0
image: gcr.io/agones-images/agones-ping:1.6.0-4d502c0
Linux C++ SDK (build): agonessdk-1.6.0-4d502c0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-4d502c0.zip

A preview of the website (the last 30 builds are retained):

https://4d502c0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1585/head:pr_1585 && git checkout pr_1585
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-4d502c0

pkg/metrics/gameservers_count.go

tests fix

akremsa · 2020-05-28T13:50:56Z

@aLekSer is right. I was checking gameservers_count metric and found that gs amount is different for each namespace. Fixed in the latest commit. @markmandel please check.

agones-bot · 2020-05-28T13:56:06Z

Build Failed 😱

Build Id: 8b21ab52-9f4a-48e2-bbb4-54a26629a5f4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-05-28T14:22:58Z

Build Succeeded 👏

Build Id: 0520c2d4-c6d3-4d75-924b-7948ec581de1

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-eb20357
image: gcr.io/agones-images/agones-sdk:1.6.0-eb20357
image: gcr.io/agones-images/agones-ping:1.6.0-eb20357
Linux C++ SDK (build): agonessdk-1.6.0-eb20357-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-eb20357.zip

A preview of the website (the last 30 builds are retained):

https://eb20357-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1585/head:pr_1585 && git checkout pr_1585
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-eb20357

pkg/metrics/controller_test.go

pkg/metrics/gameservers_count.go

aLekSer

Left some small comments. Overall looks promising.

make none to be a constant removed redundant output used for debug

agones-bot · 2020-05-28T16:24:44Z

Build Succeeded 👏

Build Id: a0e95e54-4cd2-4db8-a683-51152f9d3aa3

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-8c0702f
image: gcr.io/agones-images/agones-sdk:1.6.0-8c0702f
image: gcr.io/agones-images/agones-ping:1.6.0-8c0702f
Linux C++ SDK (build): agonessdk-1.6.0-8c0702f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-8c0702f.zip

A preview of the website (the last 30 builds are retained):

https://8c0702f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1585/head:pr_1585 && git checkout pr_1585
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-8c0702f

aLekSer

Now this PR looks nice.

google-oss-robot · 2020-05-28T17:59:51Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akremsa, aLekSer
To complete the pull request process, please assign roberthbailey
You can assign the PR to them by writing /assign @roberthbailey in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-05-28T18:00:03Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-05-28T18:17:54Z

Build Succeeded 👏

Build Id: 97a858d2-421d-4dbb-9ea7-8bb0aea909f5

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-34e3b32
image: gcr.io/agones-images/agones-sdk:1.7.0-34e3b32
image: gcr.io/agones-images/agones-ping:1.7.0-34e3b32
Linux C++ SDK (build): agonessdk-1.7.0-34e3b32-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-34e3b32.zip

A preview of the website (the last 30 builds are retained):

https://34e3b32-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1585/head:pr_1585 && git checkout pr_1585
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-34e3b32

agones-bot · 2020-05-29T21:55:08Z

Build Succeeded 👏

Build Id: 9cbd3d86-cfae-4dad-b95f-0dc3662faa0e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-c6a3c22
image: gcr.io/agones-images/agones-sdk:1.7.0-c6a3c22
image: gcr.io/agones-images/agones-ping:1.7.0-c6a3c22
Linux C++ SDK (build): agonessdk-1.7.0-c6a3c22-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-c6a3c22.zip

A preview of the website (the last 30 builds are retained):

https://c6a3c22-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1585/head:pr_1585 && git checkout pr_1585
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-c6a3c22

…leforgames#1585) * Added namespace to recordFleetReplicas Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com> Co-authored-by: Mark Mandel <markmandel@google.com>

google-oss-robot requested review from markmandel and pooneh-m May 26, 2020 15:39

google-oss-robot added the size/M label May 26, 2020

akremsa changed the title ~~Metrics: add namespace to distinguish same name fleets~~ Metrics: add namespace to distinguish fleets with the same name May 26, 2020

akremsa force-pushed the metrics-add-namespace branch from bbdce14 to 4d502c0 Compare May 27, 2020 11:25

google-oss-robot added size/L and removed size/M labels May 27, 2020

akremsa force-pushed the metrics-add-namespace branch from 4d502c0 to 94952b9 Compare May 27, 2020 11:28

aLekSer reviewed May 28, 2020

View reviewed changes

pkg/metrics/gameservers_count.go Outdated Show resolved Hide resolved

alexey-kremsa-globant added 2 commits May 28, 2020 16:48

Added namespace to recordFleetReplicas

32285c8

other metrics

b0e806a

tests fix

akremsa force-pushed the metrics-add-namespace branch from 94952b9 to 05c4ca9 Compare May 28, 2020 13:48

akremsa force-pushed the metrics-add-namespace branch from 05c4ca9 to eb20357 Compare May 28, 2020 14:03

aLekSer reviewed May 28, 2020

View reviewed changes

pkg/metrics/controller_test.go Outdated Show resolved Hide resolved

aLekSer reviewed May 28, 2020

View reviewed changes

pkg/metrics/gameservers_count.go Show resolved Hide resolved

aLekSer suggested changes May 28, 2020

View reviewed changes

google-oss-robot assigned aLekSer May 28, 2020

fixed gameserver count metric

8c0702f

make none to be a constant removed redundant output used for debug

akremsa force-pushed the metrics-add-namespace branch from eb20357 to 8c0702f Compare May 28, 2020 16:07

akremsa requested a review from aLekSer May 28, 2020 16:34

aLekSer approved these changes May 28, 2020

View reviewed changes

google-oss-robot added the lgtm label May 28, 2020

Merge branch 'master' into metrics-add-namespace

34e3b32

google-oss-robot removed the lgtm label May 28, 2020

markmandel added area/operations Installation, updating, metrics etc kind/feature New features for Agones labels May 29, 2020

markmandel added this to the 1.7.0 milestone May 29, 2020

Merge branch 'master' into metrics-add-namespace

c6a3c22

markmandel merged commit 024af01 into googleforgames:master May 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Metrics: add namespace to distinguish fleets with the same name #1585

Metrics: add namespace to distinguish fleets with the same name #1585

akremsa commented May 26, 2020 •

edited

Loading

agones-bot commented May 26, 2020

aLekSer commented May 26, 2020 •

edited

Loading

aLekSer commented May 26, 2020

markmandel commented May 26, 2020

agones-bot commented May 27, 2020

agones-bot commented May 27, 2020

akremsa commented May 28, 2020

agones-bot commented May 28, 2020

agones-bot commented May 28, 2020

aLekSer left a comment

agones-bot commented May 28, 2020

aLekSer left a comment

google-oss-robot commented May 28, 2020

google-oss-robot commented May 28, 2020

agones-bot commented May 28, 2020

agones-bot commented May 29, 2020

Metrics: add namespace to distinguish fleets with the same name #1585

Metrics: add namespace to distinguish fleets with the same name #1585

Conversation

akremsa commented May 26, 2020 • edited Loading

agones-bot commented May 26, 2020

aLekSer commented May 26, 2020 • edited Loading

aLekSer commented May 26, 2020

markmandel commented May 26, 2020

agones-bot commented May 27, 2020

agones-bot commented May 27, 2020

akremsa commented May 28, 2020

agones-bot commented May 28, 2020

agones-bot commented May 28, 2020

aLekSer left a comment

Choose a reason for hiding this comment

agones-bot commented May 28, 2020

aLekSer left a comment

Choose a reason for hiding this comment

google-oss-robot commented May 28, 2020

google-oss-robot commented May 28, 2020

agones-bot commented May 28, 2020

agones-bot commented May 29, 2020

akremsa commented May 26, 2020 •

edited

Loading

aLekSer commented May 26, 2020 •

edited

Loading