Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player Tracking Proto: Players => players #1560

Merged
merged 3 commits into from
May 15, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Fix this up so it also conforms to naming conventions.

Which issue(s) this PR fixes:

Work on #1033

Special notes for your reviewer:

None

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label May 15, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 564d265a-f12a-4605-b7d6-e39efd1448d1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

Fix this up so it also conforms to naming conventions.

Work on googleforgames#1033
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: de763ab0-90cf-4ea8-a644-059bba06ee66

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1560/head:pr_1560 && git checkout pr_1560
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-02c05b0

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 26738606-ea20-4f89-bbc5-5cc3eaaa3868

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 09c86c15-8cf0-40dc-897c-7aed5810d40a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1560/head:pr_1560 && git checkout pr_1560
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-70b53c0

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a7941848-b30e-4467-958a-74f70a8a7f04

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bf1c2571-500b-47a3-92fc-1f750e21daf0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1560/head:pr_1560 && git checkout pr_1560
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-7fb05f8

@markmandel markmandel merged commit 0e67862 into googleforgames:master May 15, 2020
@markmandel markmandel added this to the 1.6.0 milestone May 15, 2020
@markmandel markmandel deleted the cleanup/proto-players branch May 15, 2020 23:32
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Fix this up so it also conforms to naming conventions.

Work on googleforgames#1033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants