Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Event to Player Capacity update #1497

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Useful for an audit trail on your GameServer

Looks like I missed this on initial implementation.

Which issue(s) this PR fixes:

Work on #1033

Special notes for your reviewer:

None.

Looks like I missed this on initial implementation.

Work on googleforgames#1033
@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Apr 25, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5ed5c884-7201-40a0-b115-e66e008b4764

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1497/head:pr_1497 && git checkout pr_1497
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-a22c4d0

@markmandel markmandel requested review from aLekSer and removed request for EricFortin April 28, 2020 15:41
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c9729714-0e60-4800-b5a4-a10597f491e0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1497/head:pr_1497 && git checkout pr_1497
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-7f150b8

Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More logging and events is better.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer merged commit 387188a into googleforgames:master Apr 29, 2020
@markmandel markmandel deleted the feature/capacity-event branch April 29, 2020 13:41
@markmandel markmandel added this to the 1.6.0 milestone May 19, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Looks like I missed this on initial implementation.

Work on googleforgames#1033

Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants