Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go modules for a website and update go version #1457

Merged
merged 2 commits into from
Apr 8, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Apr 8, 2020

make site-deploy target is working properly.

Closes #1295 .

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 76b32bb2-b822-4579-a502-73830bad983b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

`make site-deploy` target is working properly.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 13aa6260-24e9-4d34-9927-94eb5e3124fc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1457/head:pr_1457 && git checkout pr_1457
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-3c5a86f

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4608bba7-9b1e-456b-b552-d71d8a924ff2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1457/head:pr_1457 && git checkout pr_1457
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-1f60bac

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f294b8db-2ef6-408d-836f-5340f4cc3dca

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1457/head:pr_1457 && git checkout pr_1457
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-9976785

@aLekSer aLekSer marked this pull request as ready for review April 8, 2020 16:06
@aLekSer
Copy link
Collaborator Author

aLekSer commented Apr 8, 2020

This version works on CI. However I could not run

 gcloud builds submit  . --config=./site/cloudbuild.yaml

...
Step #3: docker run --rm -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.helm:/root/.helm -v /workspace:/go/src/agones.dev/agones -v /workspace/build//.gomod:/go/pkg
/mod -v /workspace/build//.gocache:/root/.cache/go-build --workdir=/go/src/agones.dev/agones/site  agones-build:8f473e7ff2 bash -c \                                                                       
Step #3:        "HUGO_ENV=production hugo --config=config.toml "                                                                                                                                           
Step #3: Building sites … ERROR 2020/04/08 15:45:41 Failed to read Git log: fatal: Not a git repository (or any parent up to mount point /go/src/agones.dev/agones)                                        
Step #3: Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).                                                                                                                        
Step #3: Total in 1693 ms                                                                                                                                                                                  
Step #3: Error: Error building site: logged 1 error(s)                                  

Which is failing on make site-static step.
So additional check of changes in ./site/cloudbuild.yaml should be done. I probably use wrong gcloud builds command which does not load .git directory or something like that.

@markmandel markmandel added area/site The website itself - including redirects, styling, search, etc kind/cleanup Refactoring code, fixing up documentation, etc labels Apr 8, 2020
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit 2215f8d into googleforgames:master Apr 8, 2020
@markmandel markmandel added this to the 1.5.0 milestone Apr 8, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
* Use go modules for a website and update go version

`make site-deploy` target is working properly.

* Remove faking the GOPATH step in cloudbuild yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/site The website itself - including redirects, styling, search, etc kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move /site to go.mod and Go 1.12/1.13
4 participants