Index out of range error in e2e TestFleetGSSpecValidation

[akremsa]

While running e2e tests (make test-e2e) on latest master I've noticed the following error:

--- FAIL: TestFleetGSSpecValidation (0.06s)
fleet_test.go:589:
Error Trace: fleet_test.go:589
Error: "[{FieldValueInvalid Could not find a container named testing container}]" should have 2 item(s), but has 1
Test: TestFleetGSSpecValidation
panic: runtime error: index out of range [1] with length 1 [recovered]
panic: runtime error: index out of range [1] with length 1
goroutine 172 [running]:
testing.tRunner.func1(0xc0002ccb00)
/usr/local/go/src/testing/testing.go:874 +0x69f
panic(0x1ba08a0, 0xc000443f40)
/usr/local/go/src/runtime/panic.go:679 +0x1b2
agones.dev/agones/test/e2e.TestFleetGSSpecValidation(0xc0002ccb00)
/go/src/agones.dev/agones/test/e2e/fleet_test.go:592 +0x1a4a
testing.tRunner(0xc0002ccb00, 0x1cfb548)
/usr/local/go/src/testing/testing.go:909 +0x19a
created by testing.(*T).Run
/usr/local/go/src/testing/testing.go:960 +0x652
FAIL agones.dev/agones/test/e2e 49.488s

This error is related to recent changes introduced in #1396. At this point tests execution breaks.
After applying my fix I'm able to run the whole bunch of tests without any interruptions.

What do you think?

[agones-bot]

Build Succeeded 👏

Build Id: 39b98618-1274-453a-8c71-b35154e6195e

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.5.0-0eb73c3
• image: gcr.io/agones-images/agones-sdk:1.5.0-0eb73c3
• image: gcr.io/agones-images/agones-ping:1.5.0-0eb73c3
• Linux C++ SDK (build): agonessdk-1.5.0-0eb73c3-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.5.0-0eb73c3.zip

A preview of the website (the last 30 builds are retained):

• https://0eb73c3-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1439/head:pr_1439 && git checkout pr_1439
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-0eb73c3

[agones-bot]

Build Succeeded 👏

Build Id: 7620026c-5816-4479-b65d-eb25f81354da

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.5.0-5ed3681
• image: gcr.io/agones-images/agones-sdk:1.5.0-5ed3681
• image: gcr.io/agones-images/agones-ping:1.5.0-5ed3681
• Linux C++ SDK (build): agonessdk-1.5.0-5ed3681-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.5.0-5ed3681.zip

A preview of the website (the last 30 builds are retained):

• https://5ed3681-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1439/head:pr_1439 && git checkout pr_1439
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-5ed3681

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment