Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add description for Kubernetes client metrics #1409

Merged
merged 3 commits into from
Mar 17, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Mar 12, 2020

Fix sdkServer logLevel parameter name in reference.

Add Allocator grafana dashboard link to the docs.

Fix sdkServer logLevel parameter name in reference
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4fb2c0de-be84-4e06-8e83-daebbfcbbbf2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1409/head:pr_1409 && git checkout pr_1409
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-6b65bb3

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 193f5e99-37d6-45f4-bc44-a1c1cf245e1d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1409/head:pr_1409 && git checkout pr_1409
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-fa564de

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b19b6e9f-c6d7-4a2b-b13b-223001310432

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1409/head:pr_1409 && git checkout pr_1409
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-91d451d

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume these fields are correct (I did a quick scan on a few of them 👍 )

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: adb9cfcd-816a-4bb0-a6ef-d56e98ef1e4a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 92a5c72b-b792-438c-be6c-7aec5f33a548

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a481a80e-c16a-4ab8-a7f1-b2f0b180e120

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8c83caa6-eca6-4647-be3d-fe2f99febe55

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a4121cb4-c8e9-4fdd-b663-94fab88f078d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1409/head:pr_1409 && git checkout pr_1409
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-74d433b

@markmandel markmandel merged commit 0bddd60 into googleforgames:master Mar 17, 2020
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Mar 17, 2020
@markmandel markmandel added this to the 1.5.0 milestone Mar 17, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Fix sdkServer logLevel parameter name in reference

Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants