Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed dockerfile from build-allocation-images #1382

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Removed dockerfile from build-allocation-images #1382

merged 1 commit into from
Mar 3, 2020

Conversation

akremsa
Copy link
Contributor

@akremsa akremsa commented Mar 3, 2020

This PR is related to #1115

Removed dockerfile from build-allocation-images and refactored allocation.mk

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 90c50140-4e19-41c4-bd5a-b87746395ded

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1382/head:pr_1382 && git checkout pr_1382
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-2456e05

@akremsa
Copy link
Contributor Author

akremsa commented Mar 3, 2020

/assign @pooneh-m

@aLekSer
Copy link
Collaborator

aLekSer commented Mar 3, 2020

Looks good. Now there is no need in duplicate Dockerfiles for allocation and build-sdk-images.

@markmandel markmandel requested review from pooneh-m and removed request for dzlier-gcp March 3, 2020 20:04
pooneh-m
pooneh-m approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@pooneh-m pooneh-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying the build.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m pooneh-m merged commit a5889c5 into googleforgames:master Mar 3, 2020
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc labels Mar 4, 2020
@markmandel markmandel added this to the 1.4.0 milestone Mar 4, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@alexey-kremsa-globant @ilkercelikyilmaz
Removed dockerfile from build-allocation-images (googleforgames#1382)
ebc374f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooneh-m pooneh-m pooneh-m approved these changes

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@pooneh-m pooneh-m

Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/M
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@akremsa @agones-bot @aLekSer @google-oss-robot @pooneh-m @markmandel @alexey-kremsa-globant