Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player Tracking Proto and Go stubs #1312

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Player Tracking Proto and Go stubs #1312

merged 1 commit into from
Feb 13, 2020

Conversation

markmandel
Copy link
Member

Implementation of the alpha functions for player tracking in the proto definition.

This includes a interface and non-working stub for the Go gRPC clients as well.

Copyright notices where updated to 2020 on the other languages as they were regenerated during the process.

Work on #1033

@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Feb 1, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 71dd273b-8496-4173-a34d-35dc89cd8b97

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1312/head:pr_1312 && git checkout pr_1312
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-6c620d7

devjgm
devjgm approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@devjgm devjgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ changes LGTM

roberthbailey
roberthbailey reviewed Feb 7, 2020
View reviewed changes
pkg/sdkserver/alpha/localsdk.go Outdated Show resolved Hide resolved
pkg/sdkserver/alpha/sdkserver.go Outdated Show resolved Hide resolved
proto/sdk/alpha/alpha.proto Show resolved Hide resolved
@roberthbailey roberthbailey removed the request for review from EricFortin February 7, 2020 17:48
@roberthbailey roberthbailey self-assigned this Feb 7, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 61278f48-a4d7-42dc-b0f9-11931fd614a6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1312/head:pr_1312 && git checkout pr_1312
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-e40a2f6

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1d09cc1d-278e-4f55-b026-38ec6327feff

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1312/head:pr_1312 && git checkout pr_1312
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-16aa43d

@markmandel
Copy link
Member Author

Gentle bump on review please

@markmandel
Copy link
Member Author

Can I please get review on this, and #1324 , because I'm currently stuck on player tracking until these get merged.

devjgm
devjgm approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@devjgm devjgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whom you're referring to. I think I'd already approved this.

This pull-request has been approved by: devjgm, markmandel, steven-supersolid

But happy to approve again if that helps.

@markmandel
Copy link
Member Author

Thanks @devjgm but I need approval from someone with write access - so @pooneh-m or @roberthbailey at this point.

@roberthbailey
Copy link
Member

Looking now.

roberthbailey
roberthbailey reviewed Feb 13, 2020
View reviewed changes
pkg/sdkserver/alpha/sdkserver.go Outdated Show resolved Hide resolved
pkg/sdkserver/alpha/localsdk.go Outdated Show resolved Hide resolved
@markmandel
Player Tracking Proto and Go stubs
ce6c118 
Implementation of the alpha functions for player tracking in the proto
definition.

This includes a interface and non-working stub for the Go gRPC clients
as well.

Copyright notices where updated to 2020 on the other languages as they
were regenerated during the process.

Work on googleforgames#1033
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devjgm, markmandel, roberthbailey, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b45ff348-0a68-442e-ae53-7eed64dc94aa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1312/head:pr_1312 && git checkout pr_1312
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-ce6c118

@markmandel markmandel merged commit 2316a45 into googleforgames:master Feb 13, 2020
@markmandel markmandel deleted the feature/player-proto branch February 13, 2020 20:40
@markmandel markmandel added this to the 1.4.0 milestone Feb 13, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Player Tracking Proto and Go stubs (googleforgames#1312)
8776dc4 
Implementation of the alpha functions for player tracking in the proto
definition.

This includes a interface and non-working stub for the Go gRPC clients
as well.

Copyright notices where updated to 2020 on the other languages as they
were regenerated during the process.

Work on googleforgames#1033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-supersolid steven-supersolid steven-supersolid approved these changes

@roberthbailey roberthbailey roberthbailey approved these changes

@devjgm devjgm devjgm approved these changes

Assignees

@steven-supersolid steven-supersolid

@roberthbailey roberthbailey

@devjgm devjgm

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones lgtm size/XXL
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@markmandel @agones-bot @roberthbailey @google-oss-robot @steven-supersolid @devjgm