Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodejs docs: require for npm should switch on 1.3.0 #1284

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

markmandel
Copy link
Member

Missed a typo, the new code block should show up in 1.3.0 not 1.2.0

Missed a typo, the new code block should show up in 1.3.0
not 1.2.0
@markmandel markmandel added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels Jan 19, 2020
@markmandel markmandel added this to the 1.3.0 milestone Jan 19, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2ab0539b-418b-4d9d-bca9-37d1d4081aec

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1284/head:pr_1284 && git checkout pr_1284
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-6759065

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m pooneh-m merged commit 92f5b7e into googleforgames:master Jan 21, 2020
@markmandel markmandel deleted the docs/fix-nodejs branch January 21, 2020 05:34
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
)

Missed a typo, the new code block should show up in 1.3.0
not 1.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants