Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix liveness probe in the install.yaml #119

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Conversation

cyriltovena
Copy link
Collaborator

Just a little oversight

@cyriltovena cyriltovena added the kind/bug These are bugs. label Feb 28, 2018
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

I'm moving #101 into 0.2 because this is going to keep happening, and we need some kind of solution.

@markmandel markmandel merged commit 36035bf into master Feb 28, 2018
@enocom
Copy link
Contributor

enocom commented Feb 28, 2018

@Kuqd Thanks!

@markmandel Should we add a test around liveness probes for a deployed version of Agones?

@enocom enocom deleted the bug/wrong-livenessprobe branch February 28, 2018 16:42
@markmandel
Copy link
Member

@enocom #37 is a ticket. Just need to work out the best way to do it.

Or did you have another thing in mind?

@enocom
Copy link
Contributor

enocom commented Feb 28, 2018

Nope. That looks like what we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants