Skip to content

Commit

Permalink
Fixes for generated content drift
Browse files Browse the repository at this point in the history
* Include the gRPC version in the `build_sdk_base_version` version such
that it automatically gets rebuilt whenever the gRPC version changes
without manual intervention.

Also updated the changes in the allocation gRPC code as well.
  • Loading branch information
markmandel committed Oct 31, 2023
1 parent 48ccb79 commit 8238032
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions build/includes/sdk.mk
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,15 @@
# \__, |_| \_\_| \____| |_|\___/ \___/|_|_|_| |_|\__, |
# |___/ |___/

build_sdk_base_version = $(call sha,$(build_path)/build-sdk-images/tool/base/Dockerfile)
grpc_release_tag = v1.57.0

build_sdk_base_version = $(call sha,$(build_path)/build-sdk-images/tool/base/Dockerfile)_$(grpc_release_tag)
build_sdk_base_tag = agones-build-sdk-base:$(build_sdk_base_version)

# Calculate sha hash of sha hashes of all files in a specified SDK_FOLDER
build_sdk_version = $(call sha_dir,$(build_path)/build-sdk-images/$(SDK_FOLDER)/*)
build_sdk_base_remote_tag = $(REGISTRY)/$(build_sdk_base_tag)
build_sdk_prefix = agones-build-sdk-
grpc_release_tag = v1.57.0
sdk_build_folder = build-sdk-images/
examples_folder = ../examples/
SDK_FOLDER ?= go
Expand Down
2 changes: 1 addition & 1 deletion pkg/allocation/go/allocation.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/allocation/go/allocation_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8238032

Please sign in to comment.