[klippa] subset BASE table #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
reviewed
Jan 23, 2025
| pub use parsing_util::{ | ||
| parse_drop_tables, parse_name_ids, parse_name_languages, parse_unicodes, populate_gids, | ||
| parse_name_ids, parse_name_languages, parse_tag_list, parse_unicodes, populate_gids, |
There was a problem hiding this comment.
just noticing now, but are these methods genuinely part of the public API?
There was a problem hiding this comment.
oh this is because I need to use these methods in integration_test, do you know how can I export them to integration_test without making them public? I tried pub(crate) use but that doesn't work.
There was a problem hiding this comment.
yea integration test only works on public API.
qxliu76
force-pushed
the
subset_base
branch
2 times, most recently
from
d372ef5 to
f85c1d3
Compare
cmyr
approved these changes
Jan 23, 2025
thanks very much for your valuable review comments! |
garretrieger
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.