ci(java): switch to secret manager from keystore #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es user for samples tests
googlebot
added
the
cla: yes
chingor13
requested review from
stephaniewang526 and
a team
and removed request for
stephaniewang526
stephaniewang526
approved these changes
Jun 12, 2020
SurferJeffAtGoogle
approved these changes
Jun 12, 2020
|
@stephaniewang526 @SurferJeffAtGoogle Turns out we don't need to provide the service account |
bcoe
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use java-docs-samples user for samples tests.
Prototyped in googleapis/java-document-ai#100. This API requires that the service account be owned by the project that is owns the resources.