build: use checkout@v2, not v1, as this allows manual re-running of tests #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
bcoe
approved these changes
Mar 19, 2020
bcoe
added
the
do not merge
|
looks great to me @feywind, there's an approach we can use to do a mass PR, rather than letting it happen in the daily automatic update. |
SurferJeffAtGoogle
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in checkout@v2 so we can avoid the bug listed below:
actions/checkout#23
It does work with v1, but manually re-running tests will fail with a weird checkout failure. Subsequent pushes may also not properly re-run.