-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (nodejs) read repo_name and package_name from package.json #34
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
16e9f7f
feat: (nodejs) read repo_name and package_name from package.json
jkwlui d68687a
lint lint lint
jkwlui 29fee89
Merge branch 'master' into node-read-args-from-package-json
jkwlui 3c324cb
fix style; update template
jkwlui ef30fb4
Update .jsdoc.js
jkwlui bf12bdb
return all fields in package.json
jkwlui 650e001
Merge branch 'node-read-args-from-package-json' of github.com:GoogleC…
jkwlui b4e106e
linty
jkwlui 74f222f
move node tool to synthtool/languages/
jkwlui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# Copyright 2018 Google LLC | ||
This comment was marked as spam.
Sorry, something went wrong. |
||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import json | ||
|
||
|
||
def read_metadata(): | ||
""" | ||
read package name and repository in package.json from a Node library. | ||
|
||
Returns: | ||
package_name: Name of the package (with scope) | ||
repo_name: Name of the repository | ||
""" | ||
with open('./package.json') as f: | ||
data = json.load(f) | ||
|
||
package_name = data['name'] | ||
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong. |
||
repo_name = data['repository'] | ||
|
||
if package_name is None: | ||
raise RuntimeError("package.json is missing name field") | ||
if repo_name is None: | ||
raise RuntimeError("package.json is missing repository field") | ||
|
||
return {'package_name': package_name, 'repo_name': repo_name} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.