Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more templates for nodejs #23

Merged
merged 5 commits into from
Aug 1, 2018
Merged

add more templates for nodejs #23

merged 5 commits into from
Aug 1, 2018

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

JustinBeckwith
JustinBeckwith commented Aug 1, 2018
View reviewed changes
synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE.md Outdated
Please run down the following list and make sure you've tried the usual "quick
fixes":

- Search the issues already opened: https://github.com/googleapis/nodejs-storage/issues

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

theacodes
theacodes reviewed Aug 1, 2018
View reviewed changes
synthtool/gcp/templates/node_library/.github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,5 @@
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

- [ ] Tests and linter pass

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@crwilcox crwilcox mentioned this pull request Aug 1, 2018
Closed
11 tasks
jkwlui
jkwlui reviewed Aug 1, 2018
View reviewed changes
synthtool/gcp/templates/node_library/.jsdoc.js Outdated
@@ -0,0 +1,45 @@
/*!
* Copyright 2017 Google Inc. All Rights Reserved.

This comment was marked as spam.

Sign in to view

@jkwlui
Copy link
Member

jkwlui commented Aug 1, 2018

@theacodes @crwilcox I added repo_name to the node template:

https://github.com/GoogleCloudPlatform/synthtool/pull/23/files/7e26f8988c311bbd29dbc37efaad5496464664b7..a522fde6bdb17540064b4f7bbb76d4a82f0cd0a6

@jkwlui jkwlui requested review from crwilcox and removed request for crwilcox August 1, 2018 20:49
crwilcox
crwilcox approved these changes Aug 1, 2018
View reviewed changes
Copy link
Contributor

@crwilcox crwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am with @theacodes though that our PR template could be simplified by removing that checklist

@JustinBeckwith
Copy link
Contributor Author

Right now this is just mirroring the content that's already there via repo-tools :) Let's get this in now, and we can reflect on the content in a way that's consistent across languages next.

@JustinBeckwith JustinBeckwith merged commit bf5b90e into googleapis:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes left review comments

@jkwlui jkwlui jkwlui left review comments

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JustinBeckwith @jkwlui @theacodes @crwilcox