Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add Ruby-specific tools #22

Merged
merged 9 commits into from
Aug 20, 2018

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Jul 31, 2018

A module containing common Ruby-specific tools that we are using across multiple synth scripts. Currently there is a merge function (see #21) for gemspec files, and a procedure for deleting a specific named Ruby method out of a file (which we use regularly for partial gapics).

I haven't yet been able to get nox to work locally, so there might be lint issues...

@theacodes
Copy link
Contributor

I'd love to see tests for this at some point. Let's see if Kokoro passes lint and stuff.

@theacodes theacodes added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 10, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 10, 2018
@dazuma
Copy link
Member Author

dazuma commented Aug 10, 2018

I modified updated the merge_gemspec method to match what we eventually ended up using in the ruby synth scripts.

@theacodes
Copy link
Contributor

Seems lint is failing, can you run nox -s blacken to fix?

@dazuma
Copy link
Member Author

dazuma commented Aug 10, 2018

I haven't been able to get nox to work. I get this:

Traceback (most recent call last):
  File "/usr/local/google/home/dazuma/opt/asdf/installs/python/3.6.5/bin/nox", line 7, in <module>
    from nox.main import main
  File "/usr/local/google/home/dazuma/src/github/synthtool/nox.py", line 18, in <module>
    @nox.session(python='3.6')
AttributeError: module 'nox' has no attribute 'session'

@theacodes
Copy link
Contributor

theacodes commented Aug 10, 2018 via email

@jkwlui
Copy link
Member

jkwlui commented Aug 17, 2018

I haven't been able to get nox to work. I get this:

Same here.

Change-Id: I965ffa39ea9169e09c743f29fd8b947d5ac50306
@theacodes theacodes merged commit 942fe21 into googleapis:master Aug 20, 2018
@dazuma dazuma deleted the ruby-tools branch November 19, 2018 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants