Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python): Block pushing non-cloud libraries to Cloud RAD #1262

Merged
merged 4 commits into from
Oct 25, 2021
Merged

chore(python): Block pushing non-cloud libraries to Cloud RAD #1262

merged 4 commits into from
Oct 25, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 21, 2021

This PR will eliminate the need for the following replacements in owlbot.py:

# Block pushing non-cloud libraries to Cloud RAD
s.replace(
    ".kokoro/docs/common.cfg",
    r'value: "docs-staging-v2"',
    r'value: "docs-staging-v2-staging"'
)

As an example, see this replacement in python-analytics-admin.

@parthea parthea requested a review from dandhlee October 21, 2021 00:22
@parthea parthea requested a review from a team October 21, 2021 00:22
@parthea parthea requested a review from a team as a code owner October 21, 2021 00:22
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2021
@parthea
Copy link
Contributor Author

parthea commented Oct 21, 2021

@dandhlee Please could you take a look? This change will ensure that newly generated client libraries will automatically be configured correctly.

@parthea parthea changed the title chore(python): push cloud library docs to staging bucket for Cloud RAD chore(python): only push cloud library docs to the staging bucket for Cloud RAD Oct 21, 2021
@parthea parthea changed the title chore(python): only push cloud library docs to the staging bucket for Cloud RAD chore(python): Block pushing non-cloud libraries to Cloud RAD Oct 21, 2021
dandhlee
dandhlee approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! This looks great, thank you for doing this. It will be super helpful.

@dandhlee dandhlee mentioned this pull request Oct 21, 2021
Open
This was referenced Oct 21, 2021
Merged
Merged
Closed
@parthea parthea assigned busunkim96 and unassigned dandhlee Oct 21, 2021
@parthea parthea merged commit 7fd61f8 into master Oct 25, 2021
@parthea parthea deleted the configure-storage-bucket-for-cloud-rad branch October 25, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

@dandhlee dandhlee dandhlee approved these changes

@bcoe bcoe Awaiting requested review from bcoe

@SurferJeffAtGoogle SurferJeffAtGoogle Awaiting requested review from SurferJeffAtGoogle

Assignees

@busunkim96 busunkim96

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parthea @chingor13 @dandhlee @busunkim96