Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support error code for single shot upload #698

Closed

Conversation

Tulsishah
Copy link
Contributor

Fixes #694

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (61bce3c) to head (a1aff3c).
Report is 51 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
+ Coverage   98.69%   98.72%   +0.03%     
==========================================
  Files          50       50              
  Lines        8492     8623     +131     
==========================================
+ Hits         8381     8513     +132     
+ Misses        111      110       -1     
Flag Coverage Δ
unittests 98.72% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tulsishah Tulsishah force-pushed the fix_error_code_for_single_shot branch from a1aff3c to 49de595 Compare October 27, 2024 08:53
@Tulsishah Tulsishah closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return error codes are not working for single shot uploads
1 participant