feat: support bucket soft-delete policies #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
==========================================
+ Coverage 98.60% 98.63% +0.03%
==========================================
Files 50 50
Lines 8072 8365 +293
==========================================
+ Hits 7959 8251 +292
- Misses 113 114 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cojenco
reviewed
Feb 16, 2024
gcs/bucket.py
Outdated
| ) | ||
| if policy.retention_duration.ToSeconds() >= 365 * 86400: | ||
| testbench.error.invalid( | ||
| "SoftDeletePolicy.retention_duration should be at less than a year", |
There was a problem hiding this comment.
Is soft delete retention_duration maximum 90 days? This is what I see in the user guide:
The value must be greater than or equal to 604,800 seconds (7 days) and less than 7,776,000 seconds (90 days)
nit: extra at within error message
There was a problem hiding this comment.
Changed to 90d. The .proto file says 365:
🤷
cojenco
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for googleapis/google-cloud-cpp#13575