Skip to content
This repository has been archived by the owner on May 29, 2023. It is now read-only.

build!: update build configuration enable engines strict #797

Merged
merged 11 commits into from
Oct 6, 2020

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/d923dd20-12e5-4e58-82e9-642b59bc9fd4/targets

  • To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@fdd03c1
Source-Link: googleapis/synthtool@8cf6d28

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
Source-Author: Benjamin E. Coe <bencoe@google.com>
Source-Date: Wed Aug 26 14:28:22 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 8cf6d2834ad14318e64429c3b94f6443ae83daf9
Source-Link: googleapis/synthtool@8cf6d28
…ncy versions

Source-Author: Megan Potter <57276408+feywind@users.noreply.github.com>
Source-Date: Fri Sep 11 18:47:00 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: fdd03c161003ab97657cc0218f25c82c89ddf4b6
Source-Link: googleapis/synthtool@fdd03c1
@yoshi-automation yoshi-automation requested a review from a team as a code owner September 12, 2020 13:11
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 12, 2020
@codecov
Copy link

codecov bot commented Sep 12, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b8931cf). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #797   +/-   ##
========================================
  Coverage          ?   1.66%           
========================================
  Files             ?       8           
  Lines             ?    1383           
  Branches          ?       0           
========================================
  Hits              ?      23           
  Misses            ?    1360           
  Partials          ?       0           
Impacted Files Coverage Δ
.mocharc.js 79.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8931cf...5eb5072. Read the comment docs.

@JustinBeckwith JustinBeckwith changed the title [CHANGE ME] Re-generated to pick up changes from synthtool. build: use engines-strict and recursive tests Sep 12, 2020
@JustinBeckwith JustinBeckwith added the automerge Merge the pull request once unit tests and other checks pass. label Sep 12, 2020
@gcf-merge-on-green
Copy link

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 13, 2020
@product-auto-label product-auto-label bot added the api: cloudbuild Issues related to the Cloud Build API. label Sep 13, 2020
@bcoe bcoe changed the title build: use engines-strict and recursive tests build!: update build configuration enable engines strict Sep 15, 2020
@bcoe
Copy link
Contributor

bcoe commented Sep 15, 2020

see: Inist-CNRS/node-csv-string#49

@bcoe bcoe merged commit 6e8458a into master Oct 6, 2020
This was referenced Oct 6, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 7, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
### [5.36.2](https://www.github.com/googleapis/sloth/compare/v5.36.1...v5.36.2) (2020-10-07)


### ⚠ BREAKING CHANGES

* update build configuration enable engines strict (#797)

### Bug Fixes

* **build:** switch to trampoline 2 (release as patch rather than major) ([#813](https://www.github.com/googleapis/sloth/issues/813)) ([ee3a1bd](https://www.github.com/googleapis/sloth/commit/ee3a1bd4f0174d9b5fc9b187d1e185abdc5c71e2))


### Build System

* update build configuration enable engines strict ([#797](https://www.github.com/googleapis/sloth/issues/797)) ([6e8458a](https://www.github.com/googleapis/sloth/commit/6e8458a1299a2f5b7deec810b586138528cb0786))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: cloudbuild Issues related to the Cloud Build API. cla: yes This human has signed the Contributor License Agreement. context: partial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants