feat(resnames)!: Do not generate unused resname classes [ggj]

src/main/java/com/google/api/generator/gapic/protoparser/Parser.java

@@ -142,6 +142,9 @@ public static GapicContext parse(CodeGeneratorRequest request) {
     Map<String, ResourceName> resourceNames = parseResourceNames(request);
     messages = updateResourceNamesInMessages(messages, resourceNames.values());
 
+    // Contains only resource names that are actually used. That is, resource name definitions
+    // or references that are simply defined, but not used, will not have corresponding Java helper
+    // classes generated.
     Set<ResourceName> outputArgResourceNames = new HashSet<>();
     List<Service> mixinServices = new ArrayList<>();
     Transport transport = Transport.parse(transportOpt.orElse(Transport.GRPC.toString()));
@@ -157,33 +160,6 @@ public static GapicContext parse(CodeGeneratorRequest request) {
             transport);
 
     Preconditions.checkState(!services.isEmpty(), "No services found to generate");
-    Function<ResourceName, String> typeNameFn =
-        r -> r.resourceTypeString().substring(r.resourceTypeString().indexOf("/") + 1);
-    Function<Set<ResourceName>, Set<String>> typeStringSetFn =
-        sr -> sr.stream().map(r -> typeNameFn.apply(r)).collect(Collectors.toSet());
-
-    // Include all resource names present in message types for backwards-compatibility with the
-    // monolith. In the future, this should be removed on a client library major semver update.
-    // Resolve type name collisions with the ones present in the method arguments.
-    final Set<String> typeStringSet = typeStringSetFn.apply(outputArgResourceNames);
-    outputArgResourceNames.addAll(
-        resourceNames.values().stream()
-            .filter(r -> r.hasParentMessageName() && !typeStringSet.contains(typeNameFn.apply(r)))
-            .collect(Collectors.toSet()));
-
-    String servicePackage = services.get(0).pakkage();
-    Map<String, ResourceName> patternsToResourceNames =
-        ResourceParserHelpers.createPatternResourceNameMap(resourceNames);
-    for (ResourceReference resourceReference : outputResourceReferencesSeen) {
-      final Set<String> interimTypeStringSet = typeStringSetFn.apply(outputArgResourceNames);
-      outputArgResourceNames.addAll(
-          ResourceReferenceParser.parseResourceNames(
-                  resourceReference, servicePackage, null, resourceNames, patternsToResourceNames)
-              .stream()
-              .filter(r -> !interimTypeStringSet.contains(typeNameFn.apply(r)))
-              .collect(Collectors.toSet()));
-    }
-
     return GapicContext.builder()
         .setServices(services)
         .setMixinServices(mixinServices)

test/integration/goldens/iam/com/google/iam/v1/package-info.java

@@ -48,7 +48,7 @@
  * try (IAMPolicyClient iAMPolicyClient = IAMPolicyClient.create()) {
  *   SetIamPolicyRequest request =
  *       SetIamPolicyRequest.newBuilder()
- *           .setResource("SetIamPolicyRequest1223629066".toString())
+ *           .setResource("resource-341064690")
  *           .setPolicy(Policy.newBuilder().build())
  *           .build();
  *   Policy response = iAMPolicyClient.setIamPolicy(request);

test/integration/goldens/kms/com/google/cloud/kms/v1/KeyManagementServiceClientTest.java

@@ -752,14 +752,7 @@ public void getPublicKeyTest() throws Exception {
         PublicKey.newBuilder()
             .setPem("pem110872")
             .setPemCrc32C(Int64Value.newBuilder().build())
-            .setName(
-                PublicKeyName.of(
-                        "[PROJECT]",
-                        "[LOCATION]",
-                        "[KEY_RING]",
-                        "[CRYPTO_KEY]",
-                        "[CRYPTO_KEY_VERSION]")
-                    .toString())
+            .setName("name3373707")
             .build();
     mockKeyManagementService.addResponse(expectedResponse);
 
@@ -803,14 +796,7 @@ public void getPublicKeyTest2() throws Exception {
         PublicKey.newBuilder()
             .setPem("pem110872")
             .setPemCrc32C(Int64Value.newBuilder().build())
-            .setName(
-                PublicKeyName.of(
-                        "[PROJECT]",
-                        "[LOCATION]",
-                        "[KEY_RING]",
-                        "[CRYPTO_KEY]",
-                        "[CRYPTO_KEY_VERSION]")
-                    .toString())
+            .setName("name3373707")
             .build();
     mockKeyManagementService.addResponse(expectedResponse);