Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generator setting incorrect name/class for sample due to region tag (2nd attempt) #3293

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: generator setting incorrect name/class for sample due to region tag (2nd attempt) #3293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...com/google/api/generator/gapic/composer/samplecode/ServiceClientHeaderSampleComposer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ public static Sample composeTransportSample(
RegionTag.builder()
.setServiceName(service.name())
.setRpcName(rpcName)
.setOverloadDisambiguation("setCredentialsProvider")
.setOverloadDisambiguation("useHttpJsonTransport")
.build();
return Sample.builder().setBody(sampleBody).setRegionTag(regionTag).build();
}
Expand Down
10 changes: 5 additions & 5 deletions ...te/SyncCreateSetCredentialsProvider1.java → ...reate/SyncCreateUseHttpJsonTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@

package com.google.cloud.apigeeconnect.v1.samples;

// [START apigeeconnect_v1_generated_ConnectionService_Create_SetCredentialsProvider1_sync]
// [START apigeeconnect_v1_generated_ConnectionService_Create_UseHttpJsonTransport_sync]
import com.google.cloud.apigeeconnect.v1.ConnectionServiceClient;
import com.google.cloud.apigeeconnect.v1.ConnectionServiceSettings;

public class SyncCreateSetCredentialsProvider1 {
public class SyncCreateUseHttpJsonTransport {

public static void main(String[] args) throws Exception {
syncCreateSetCredentialsProvider1();
syncCreateUseHttpJsonTransport();
}

public static void syncCreateSetCredentialsProvider1() throws Exception {
public static void syncCreateUseHttpJsonTransport() throws Exception {
// This snippet has been automatically generated and should be regarded as a code template only.
// It will require modifications to work:
// - It may require correct/in-range values for request initialization.
Expand All @@ -38,4 +38,4 @@ public static void syncCreateSetCredentialsProvider1() throws Exception {
ConnectionServiceClient.create(connectionServiceSettings);
}
}
// [END apigeeconnect_v1_generated_ConnectionService_Create_SetCredentialsProvider1_sync]
// [END apigeeconnect_v1_generated_ConnectionService_Create_UseHttpJsonTransport_sync]
10 changes: 5 additions & 5 deletions ...te/SyncCreateSetCredentialsProvider1.java → ...reate/SyncCreateUseHttpJsonTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@

package com.google.cloud.asset.v1.samples;

// [START cloudasset_v1_generated_AssetService_Create_SetCredentialsProvider1_sync]
// [START cloudasset_v1_generated_AssetService_Create_UseHttpJsonTransport_sync]
import com.google.cloud.asset.v1.AssetServiceClient;
import com.google.cloud.asset.v1.AssetServiceSettings;

public class SyncCreateSetCredentialsProvider1 {
public class SyncCreateUseHttpJsonTransport {

public static void main(String[] args) throws Exception {
syncCreateSetCredentialsProvider1();
syncCreateUseHttpJsonTransport();
}

public static void syncCreateSetCredentialsProvider1() throws Exception {
public static void syncCreateUseHttpJsonTransport() throws Exception {
// This snippet has been automatically generated and should be regarded as a code template only.
// It will require modifications to work:
// - It may require correct/in-range values for request initialization.
Expand All @@ -36,4 +36,4 @@ public static void syncCreateSetCredentialsProvider1() throws Exception {
AssetServiceClient assetServiceClient = AssetServiceClient.create(assetServiceSettings);
}
}
// [END cloudasset_v1_generated_AssetService_Create_SetCredentialsProvider1_sync]
// [END cloudasset_v1_generated_AssetService_Create_UseHttpJsonTransport_sync]
10 changes: 5 additions & 5 deletions ...te/SyncCreateSetCredentialsProvider1.java → ...reate/SyncCreateUseHttpJsonTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@

package com.google.cloud.iam.credentials.v1.samples;

// [START iamcredentials_v1_generated_IAMCredentials_Create_SetCredentialsProvider1_sync]
// [START iamcredentials_v1_generated_IAMCredentials_Create_UseHttpJsonTransport_sync]
import com.google.cloud.iam.credentials.v1.IamCredentialsClient;
import com.google.cloud.iam.credentials.v1.IamCredentialsSettings;

public class SyncCreateSetCredentialsProvider1 {
public class SyncCreateUseHttpJsonTransport {

public static void main(String[] args) throws Exception {
syncCreateSetCredentialsProvider1();
syncCreateUseHttpJsonTransport();
}

public static void syncCreateSetCredentialsProvider1() throws Exception {
public static void syncCreateUseHttpJsonTransport() throws Exception {
// This snippet has been automatically generated and should be regarded as a code template only.
// It will require modifications to work:
// - It may require correct/in-range values for request initialization.
Expand All @@ -37,4 +37,4 @@ public static void syncCreateSetCredentialsProvider1() throws Exception {
IamCredentialsClient iamCredentialsClient = IamCredentialsClient.create(iamCredentialsSettings);
}
}
// [END iamcredentials_v1_generated_IAMCredentials_Create_SetCredentialsProvider1_sync]
// [END iamcredentials_v1_generated_IAMCredentials_Create_UseHttpJsonTransport_sync]
10 changes: 5 additions & 5 deletions ...te/SyncCreateSetCredentialsProvider1.java → ...reate/SyncCreateUseHttpJsonTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@

package com.google.cloud.example.library.v1.samples;

// [START example_v1_generated_LibraryService_Create_SetCredentialsProvider1_sync]
// [START example_v1_generated_LibraryService_Create_UseHttpJsonTransport_sync]
import com.google.cloud.example.library.v1.LibraryServiceClient;
import com.google.cloud.example.library.v1.LibraryServiceSettings;

public class SyncCreateSetCredentialsProvider1 {
public class SyncCreateUseHttpJsonTransport {

public static void main(String[] args) throws Exception {
syncCreateSetCredentialsProvider1();
syncCreateUseHttpJsonTransport();
}

public static void syncCreateSetCredentialsProvider1() throws Exception {
public static void syncCreateUseHttpJsonTransport() throws Exception {
// This snippet has been automatically generated and should be regarded as a code template only.
// It will require modifications to work:
// - It may require correct/in-range values for request initialization.
Expand All @@ -37,4 +37,4 @@ public static void syncCreateSetCredentialsProvider1() throws Exception {
LibraryServiceClient libraryServiceClient = LibraryServiceClient.create(libraryServiceSettings);
}
}
// [END example_v1_generated_LibraryService_Create_SetCredentialsProvider1_sync]
// [END example_v1_generated_LibraryService_Create_UseHttpJsonTransport_sync]
10 changes: 5 additions & 5 deletions ...te/SyncCreateSetCredentialsProvider1.java → ...reate/SyncCreateUseHttpJsonTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@

package com.google.cloud.redis.v1beta1.samples;

// [START redis_v1beta1_generated_CloudRedis_Create_SetCredentialsProvider1_sync]
// [START redis_v1beta1_generated_CloudRedis_Create_UseHttpJsonTransport_sync]
import com.google.cloud.redis.v1beta1.CloudRedisClient;
import com.google.cloud.redis.v1beta1.CloudRedisSettings;

public class SyncCreateSetCredentialsProvider1 {
public class SyncCreateUseHttpJsonTransport {

public static void main(String[] args) throws Exception {
syncCreateSetCredentialsProvider1();
syncCreateUseHttpJsonTransport();
}

public static void syncCreateSetCredentialsProvider1() throws Exception {
public static void syncCreateUseHttpJsonTransport() throws Exception {
// This snippet has been automatically generated and should be regarded as a code template only.
// It will require modifications to work:
// - It may require correct/in-range values for request initialization.
Expand All @@ -36,4 +36,4 @@ public static void syncCreateSetCredentialsProvider1() throws Exception {
CloudRedisClient cloudRedisClient = CloudRedisClient.create(cloudRedisSettings);
}
}
// [END redis_v1beta1_generated_CloudRedis_Create_SetCredentialsProvider1_sync]
// [END redis_v1beta1_generated_CloudRedis_Create_UseHttpJsonTransport_sync]
Loading