chore: change commit message #2829
Conversation
| @@ -1,23 +1,19 @@ | |||
| This pull request is generated with proto changes between googleapis commit a17d4caf184b050d50cacf2b0d579ce72c31ce74 (exclusive) and 4ce0ff67a3d4509be641cbe47a35844ddc1268fc (inclusive). | |||
There was a problem hiding this comment.
Can we make these two commit a link too?
| result = ["BEGIN_NESTED_COMMIT"] | ||
| result.extend(messages) | ||
| result.append( | ||
| f"Source Link: [googleapis/googleapis@{short_sha}](https://github.com/googleapis/googleapis/commit/{commit.hexsha})" |
There was a problem hiding this comment.
Optional nit:
FWIW Github will automatically format the link if you just write the link in plain text. That way we make the logic simple at the cost of relying on the service (is it stable?).
E.G. pasting https://github.com/googleapis/googleapis/commit/19af522bf3ab49b7d4ce284a568b2e8bb28aeae3 results in googleapis/googleapis@19af522
There was a problem hiding this comment.
Thanks for the suggestion, though I don't want to depends on github.
|
|
In this PR: