chore: add generation workflow #2825
Conversation
| - name: Build image | ||
| shell: bash | ||
| run: | | ||
| docker build \ |
There was a problem hiding this comment.
Compare to the workflow in google-cloud-java, is this the only main change?
There was a problem hiding this comment.
Changes compared to google-cloud-java
- build local image
- install gapic-generator-java-pom-parent
There was a problem hiding this comment.
An idea to get rid of the .m2 volume mapping.
Our workflows build and publish a docker image every time we merge a PR in this repo. The tag is the commit SHA of the merged (squashed) commit.
Would it be useful to run mvn install -pl ggj-pom-parent in the Dockerfile and label the image as x.x.x-SNAPSHOT as well (we can have two tags)?
There was a problem hiding this comment.
This step is specific to generate common protos.
Putting mvn install in the Dockerfile will apply to all libraries, which is a redundant step.
There was a problem hiding this comment.
I feel it's better to put these two shell scripts under .github/ as they are only used by github workflows, WDYT? Same thing for the scripts in google-cloud-java.
There was a problem hiding this comment.
I think it's fine.
| - name: Build image | ||
| shell: bash | ||
| run: | | ||
| docker build \ |
There was a problem hiding this comment.
An idea to get rid of the .m2 volume mapping.
Our workflows build and publish a docker image every time we merge a PR in this repo. The tag is the commit SHA of the merged (squashed) commit.
Would it be useful to run mvn install -pl ggj-pom-parent in the Dockerfile and label the image as x.x.x-SNAPSHOT as well (we can have two tags)?
|
|
In this PR: